1919488 - Update splashscreen background color to match application's set theme

Status: REOPENED

(Firefox for Android :: Design System and Theming, enhancement)

Description

[Petru-Mugurel Lingurar [:petru]]

Idea got from a conversation about the isSystemInDarkTheme API - https://kotlinlang.slack.com/archives/CJLTWPH7S/p1726654545685589?thread_ts=1726652145.491239&cid=CJLTWPH7S

Looks like a new API in UIModeManager - setApplicationNightMode allows to persist the application's dark theme outside of the lifecycle of AppCompatDelegate.setDefaultNightMode.
And this allows to automagically use the matching background for our splashscreen.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: AppThemeMatchingSplashscreen.mp4

What the result would be in Fenix debug vs current Nightly, both set to dark theme while the device uses light theme.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1919488 - Persist night theme changes on Android S+ r=#android-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c48aa9b6764
Persist night theme changes on Android S+ r=android-reviewers,Roger

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/2c48aa9b6764

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Attachment: Revert "Bug 1919488 - Persist night theme changes on Android S+" r=#android-reviewers

This reverts commit f26d0b8c729b1c0f0c102be4873dc024bb7bceb5.

Comment 6

[Phabricator Automation]

Comment on attachment 9444937 [details]
Revert "Bug 1919488 - Persist night theme changes on Android S+" r=#android-reviewers

Revision D232832 was moved to bug 1938824. Setting attachment 9444937 [details] to obsolete.

Comment 7

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1919488 - Apply ui mode changes to activities r=#android-reviewers

In the case of theme changes that trigger an UI mode change applies in the application
after the current activity is restarted it should also apply the new ui mode to it's
configuration.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5c5bfff3e12
Apply ui mode changes to activities r=android-reviewers,pollymce

Comment 9

[Goloman Adrian[:agoloman]]

https://hg.mozilla.org/mozilla-central/rev/a5c5bfff3e12

Comment 10

[BugBot [:suhaib / :marco]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 11

[Ryan VanderMeulen [:RyanVM]]

For the future, it would have been cleaner if the new patch had landed in bug 1938824 so we can better track cause and effect (that bug is now both effectively caused and fixed by the same bug #).

Comment 12

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/40da57a51d95
Backed out changeset a5c5bfff3e12 requested by developer.
https://hg.mozilla.org/mozilla-central/rev/a9a5b02885fb
Backed out changeset 2c48aa9b6764 because it was requested by developer.

Comment 13

[Mira Lobontiu (Android QA)]

Attachment: bug 1919488 - Trim - Trim.mp4

This is the current behavior on the latest Nightly 135.0a1 build from 12/27:

• the device's theme is different from the app's theme,
• when opening the app, the splashscreen has the same background as the device's.

Tested with Oppo Find N2 Flip (Android 14), Realme GT Master Edition (Android 13), and google Pixel 6 (Android 15).
Removing the qe-verify+ flag for now.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35b9fb7dc782
Persist night theme changes on Android S+ r=android-reviewers,Roger
https://hg.mozilla.org/integration/autoland/rev/ddd04bc48281
Apply ui mode changes to activities r=android-reviewers,pollymce

Comment 15

[amarc]

https://hg.mozilla.org/mozilla-central/rev/35b9fb7dc782
https://hg.mozilla.org/mozilla-central/rev/ddd04bc48281

Comment 16

[Petru-Mugurel Lingurar [:petru]]

@ QA These patches were previously reverted.
After being merged back please help verify here and in bug 1916300 that the splashscreen has the right background color on Android 12+ and no ill effects are observed.

Comment 17

[Mira Lobontiu (Android QA)]

Thanks Petru,

Verified on multiple devices with the Fenix Nightly 136.0a1 from 1/9.
Everything looks good on Google Pixel 6 (Android 15), Samsung Galaxy S24 (Android 14), Oppo Find N2 Flip (Android 14), Vivo v23 (Android 14). The splashscreen follows Fenix' theme, even when the device's theme is different.

However on some devices, the difference between the device's theme and the app's theme messes up the UI in Settings - I filed Bug 1940902.

Comment 18

[Petru-Mugurel Lingurar [:petru]]

The newly reported regression seems to show a race from setting both the selected theme here and the selected locale.
Seems like something specific to our implementation of in-app locale switching so I recommend re-evaluating supporting the splashscreen color updates only after moving to the new APIs for per-app language preferences that we have planned in bug 1813857.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

This was reverted again in bug 1940902.

Comment 20

[Petru-Mugurel Lingurar [:petru]]

Thanks Ryan!
Yeah, this seems too unstable in the context of other configurations that we have.
After bug 1813857 the implementation should be more straight-forward - no conflict with also applying locale changes.