1919752 - Dropping a folder for upload will give a DLP communication agent notification error

Status: RESOLVED FIXED

(Firefox :: Data Loss Prevention, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: drop.gif

Found in

• 132.0a1 (2024-09-18)

Affected versions

• 132.0a1 (2024-09-18)

Tested platforms

• Affected platforms: Windows 10x64, Windows 11
• Unaffected platforms: macOS, Ubuntu

Preconditions

• Download the DLP test assets from https://drive.google.com/file/d/1yjqVRuxdKV3WnO7D2wzMgDXBuYBxUgVw/view
• Create a distribution folder inside the Firefox folder and paste the policies-2.json to it and then rename it to policies.json
• run the DLP agent in CMD using: .\content_analysis_sdk_agent.exe --user --toblock=.\d{3}-?\d{2}-?\d{4}. --towarn=.warn. --delays=10

Steps to reproduce

1. Open https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/webkitdirectory.
2. Drag and drop a folder over the Browser button from the Examples section.

Expected result

• DLP scan is started and the content is uploaded/ not uploaded (depending on scan results)

Actual result

• DLP Agent error communication notification is displayed.

Regression range

• This happens after drag and drop scanning was introduced inside Content Analysis (bug 1910452).

Additional notes

• Attached a screen recording.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:handyman, since you are the author of the regressor, bug 1910452, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Note that this also seems to be reproducing on Google Drive and Onedrive.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1910452

Comment 4

[David Parks [:handyman]]

Attachment: Bug 1919752: Submit all files for content analysis when doing folder analysis r=#dlp-reviewers!

Converts folder scan requests, from any content analysis interception point,
into file scan requests for each file in the folder (recursively). Folder CA
approval is given iff all files were approved. Otherwise the folder analysis
result is denial, issued as soon as that is known.

This still has the issue that only the first file will be given busy and verdict
dialogs. The entire CA check may silently block because of this. See bug
1915351.

Comment 5

[David Parks [:handyman]]

Attachment: Bug 1919752: Test pasting a folder under content analysis r=#dlp-reviewers!

Comment 6

[David Parks [:handyman]]

This bug and patch series also cover the case of copy-pasting a directory.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bc82877b722
Submit all files for content analysis when doing folder analysis r=dlp-reviewers,win-reviewers,gstoll
https://hg.mozilla.org/integration/autoland/rev/e11796c0a840
Test pasting a folder under content analysis r=dlp-reviewers,gstoll

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2bc82877b722
https://hg.mozilla.org/mozilla-central/rev/e11796c0a840

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:handyman, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox132 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Hello! I tried verifying this today, but I noticed a few behaviors that I need to check if they’ll be fixed in bug 1915351 or not:

1. When dropping a folder with multiple approved files, the scan runs only the first file. After that, the scan dialogue disappears, and the files are uploaded only after scanning completes inside the agent (so, there’s a delay). (I saw this stated in comment 4 but to be safe)
2. No blocked message appears when dropping a folder that contains both a blocked file and other approved files. The files aren’t uploaded as expected but there is no message stating that. This works correctly when there’s only one blocked file in the folder. (Note that the scanning dialog is displayed only for the first file.)
3. When dropping a folder containing a warning file and an approved file (e.g. 333.pdf and warn.txt), the warning dialog incorrectly states that 333.pdf contains unsafe content instead of warn.txt.
4. When dropping a folder with a warning file and a good file, and then choosing the Use Content option on the warning dialogue, no files will be uploaded.

Can you confirm if these will be addressed in bug 1915351 or for which one should we open separate issues? Thanks!

Comment 11

[Greg Stoll :gstoll]

Hi - I tried a build with this bug fixed and the bug 1915351 fixes as well.

1, 2, and 3 appear to be fixed, but 4 is still an issue. I have also observed that if you drop a folder with multiple approved files and just click somewhere on the page while the scan is in progress, no files will be uploaded, which is probably the same problem. So please file a separate issue for 4; thanks!

Comment 12

[David Parks [:handyman]]

Are you saying that bug 1915351 fixes the missing dialogs for multiple-file scans (such as for folder scans), which should present the modal window over content during that period, but that the modal doesn't block input so clicking somewhere on the page does "something" -- it blocks the drop that was being scanned?

Comment 13

[Greg Stoll :gstoll]

Yes, I think that's what's happening. Clicking somewhere in the page doesn't make the dialog go away, but it does mean that the drop won't happen after the scan is done.

Comment 14

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: 1919752.gif

(In reply to Greg Stoll :gstoll from comment #11)

Hi - I tried a build with this bug fixed and the bug 1915351 fixes as well.

1, 2, and 3 appear to be fixed, but 4 is still an issue. I have also observed that if you drop a folder with multiple approved files and just click somewhere on the page while the scan is in progress, no files will be uploaded, which is probably the same problem. So please file a separate issue for 4; thanks!

Thank you! I have filled out bug 1923556. However, I cannot reproduce the issue with the click. The files are uploaded, but I have to wait due to the problem described at point 1. I will leave this open, and we will verify this issue again after bug 1915351 lands.