1920037 - [Toolbar Redesign] [a11y] 3 dots Menu is read as "More options" in landscape mode for browsing Menu

Status: RESOLVED FIXED

(Fenix :: Toolbar, defect, P2)

Description

[Vasilica Tamas QA [:vtamas]]

Attachment: MoreOptionsButton.mp4

Preconditions

• Enable Menu Redesign feature from Secret Settings.
• Turn on Talkback.

Steps to reproduce

1. Turn the device in landscape mode.
2. Navigate to a webpage and tap on 3 dots menu.
3. Go to homescreen and tap on 3 dots menu

Expected behavior

The Talkback reads: "Menu button. Double tap to activate”

Actual behavior

Browsing menu -> The Talkback reads: "More options button. Double tap to activate”
Homepage menu -> The Talkback reads: "Menu. Double tap to activate”

Device information

• Firefox version: Firefox Nightly 132 (2024-09-19)
• Android device model: Google Pixel 8, Samsung Galaxy S24 Ultra
• Android OS version: Android 14

Comment 1

[Chris Peterson [:cpeterson]]

Aarjav says this is a toolbar bug.

Comment 2

[Zac McKenney [:zmckenney]]

I've identified the bug for the toolbar differences and can change this to the Expected Behavior without much issue but I think we might actually want to change all Toolbar menu buttons to read "More options".

Here is our current translated string in Fenix for content_description_menu that looks to have been previously used.

We're using this Android Components translated string to now make this read "Menu".

:cpeterson, would you be able to let me know which is the correct string to use?

Comment 3

[Zac McKenney [:zmckenney]]

Attachment: Bug 1920037 - Fix talkback content description for Menu Button in toolbar

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d549a8d8aae3
Fix talkback content description for Menu Button in toolbar r=android-reviewers,pollymce

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/d549a8d8aae3

Comment 6

[Vasilica Tamas QA [:vtamas]]

Attachment: 3dotsmenu.mp4

Tested this issue on Firefox Nightly 134 (2024-11-14) under Samsung S24 Ultra and noticed that the 3 dots menu button is read as "More options button. Double tap to activate” in all cases expecting the homepage 3 dots menu from landscape mode which is still read as "Menu. Double tap to activate" in landscape mode.