1920118 - Try to unship moz-user-modify.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

Its only effect is whether we show a caret in content (so you can undisplay the caret on editable stuff or so), but that's not documented (https://developer.mozilla.org/en-US/docs/Web/CSS/user-modify claims it has no effect at all). Let's try to unship it behind a pref.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1920118 - Don't look at -moz-user-modify in InlineSpellChecker. r=Gijs

I think this is trying to make spellcheck work on designmode, but it
never works because getComputedStyle's second argument is a
pseudo-element, not a property name.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1920118 - Unship -moz-user-modify. r=#style,#layout

-moz-user-modify is a prefixed CSS property which does almost nothing.

It has some effect on caret painting (as in, you could make a
contenteditable element not paint the caret), but there are better ways
of doing that (caret-color: transparent or so).

It is also documented to do nothing in MDN.

Given that, I plan to try to remove it. Only real risk is that someone
uses for feature detection or so, so I expect the risk to be pretty
minimal.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ef7651b6fb9
Don't look at -moz-user-modify in InlineSpellChecker. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/91c94dc113f8
Unship -moz-user-modify. r=dholbert

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c25fb46f44d5
Call SimpleTest.finish() in test_bug442801.html.

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/4ef7651b6fb9
https://hg.mozilla.org/mozilla-central/rev/91c94dc113f8
https://hg.mozilla.org/mozilla-central/rev/c25fb46f44d5

Comment 6

[Dave Letorey]

Related Pull Requests

• BCD PR
• Firefox Relase note PR