1925365 - Spelling suggestions on right-click no longer working for plain text composition (HTML composition is ok)

Status: NEW

(Thunderbird :: Message Compose Window, defect, P2)

Description

[macuc]

Attachment: no_shpeling_suggestions.png

Steps to reproduce:

TB v132.0b5

• Enable Enable spell checking as you type in Composition settings.
• Click New Message and type some content with spelling errors.
• Note that words with spelling errors display a squiggly red underline under them.
• Right-click on a misspelled word.

Actual results:

• Context menu for misspelled words does not show spelling suggestions.

Expected results:

• Spelling suggestions should be displayed in the context menu, like it used to.

Note: Clicking the Spelling button in the new message header does work normally. So this does not seem to be a problem with the basic functions of spelling dictionary, or finding and replacing misspelled words.

Comment 1

[Magnus Melin [:mkmelin]]

Seems to work for me (on linux/daily)

Comment 2

[macuc]

Attachment: Working with HTML composition

Spelling suggestions work when Compose message in HTML format is enabled on the account setting.

Comment 3

[macuc]

Attachment: Plain-Text not working

Not working when Compose message as HTML is disabled in account settings.

Comment 4

[Magnus Melin [:mkmelin]]

If you have the default html composition you can shift click "New message" to get plain text composition.
I do see that yes.

Comment 5

[Alice0775 White]

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=d7a05df28f55acb954447c16f17af3cd5ca4dc5f&tochange=be902fc717335037fa91d7a400339f645a057554
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f4f1159d250a769d457738a3c8a63fe9922714ea&tochange=a021c885397e096d8bc0dd6574dc4c9873be6f99

Suspect:
91c94dc113f8b8cc460f73fabf2cb59d8d919b94 Emilio Cobos Álvarez — Bug 1920118 - Unship -moz-user-modify. r=dholbert
4ef7651b6fb98f41908a4f33905206a88384bb5c Emilio Cobos Álvarez — Bug 1920118 - Don't look at -moz-user-modify in InlineSpellChecker. r=Gijs

OR

0f470e1a67afe6044b03ba5c8dd92daa3037de8a Masayuki Nakano — Bug 1919927 - Implement contenteditable="plaintext-only" in the DOM module r=smaug

Tentatively, mark Bug 1920118 as regressor.