1920280 - Investigate whether StretchPreservingRatio enum variant can be removed

Status: RESOLVED FIXED

(Core :: Layout: Grid, task)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

After bug 1685428, we've tried to honor aspect-ratio under stretch alignment in grid layout. It seems Stretch and StretchPreservingRatio [1] might ultimately have the same meaning. We should investigate whether we can remove StretchPreservingRatio and simplify the code.

[1] https://searchfox.org/mozilla-central/rev/a6f4fbcd9b1ce352b7d6d1b87204d3e015266b57/layout/generic/nsContainerFrame.cpp#2235-2238

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1920280 Part 1 - Use two variables to store sizes that fill containing block sizes. r?#layout

The old code store them in iSize and bSize, which is confusing since they
can also store the resolved non-auto sizes.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1920280 Part 2 - Rename the enum and its variants that controls fill CB behavior. r?#layout

After fixing bug 1685428, we honor aspect-ratio under stretch alignment in grid
layout. That makes the enum variants Stretch and StretchPreservingRatio
confusing.

To clarify their distinct behaviors, this patch renames the enum and its
variants as follows:

• Stretch::NoStretch (eNoStretch) -> FillCB::No
• Stretch::Stretch (eStretch) -> FillCB::Stretch
• Stretch::StretchPreservingRatio (eStretchPreservingRatio) -> FillCB::Clamp

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1310354f3fd3
Part 1 - Use two variables to store sizes that fill containing block sizes. r=dshin
https://hg.mozilla.org/integration/autoland/rev/a9acd1328271
Part 2 - Rename the enum and its variants that controls fill CB behavior. r=dshin

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/1310354f3fd3
https://hg.mozilla.org/mozilla-central/rev/a9acd1328271