192029 - [classic/aqua] Top border of tab contents adjoining active tab should be aqua blue

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect)

Description

[Samir Gehani]

Build:
------
2003012903 Mac OS X Mach-o

Steps to reproduce:
-------------------
(1) Launch browser.
(2) Open a few tabs (cmd-T).
(3) Observer top border of paage content area immediately below tab bar.

Actual results:
---------------
Top border of tab (page) contents adjoining the tab bar is not blue, it's white.  

Expected results:
-----------------
As discussed by Sairuh, Marlon, myself and others the top border should be blue.
 See Chimera's top border as a guide.

Comment 1

[sairuh (rarely reading bugmail)]

afaik, this is limited to the aqua/classic theme on OS X (not other platforms).

Comment 2

[Samir Gehani]

The pinstripe theme [1] gets this right so it appears to be a theme issue with
the Mac OS X classic skin.  Over to Shuehan for a look.
_______________________
[1] <http://www.kmgerich.com/pinstripe/pinstripe.html>

Comment 3

[Samir Gehani]

Nav triage team: nsbeta1+/adt3

Comment 4

[Kevin Gerich]

Pinstripe "appears" to get it right. I achived that look in the theme by adding
a box below the tabs via GlobalBindings.xml and giving it a -moz-appearance:
tabpanels style. I arrived at this hack because I couldn't find a way to expose
the blue top border of the tabbrowser's tabpanel and have it be visible only
when the tab strip is shown. My hack also causes an error to appear in the
Javascript console. See <a
href="http://bugzilla.mozilla.org/show_bug.cgi?id=201196">Bug 201196</a>.

Comment 5

[shliang]

Attachment: patch

Comment 6

[jag (Peter Annema)]

While playing with the <browser> constructor (and breaking it from time to time)
I noticed that the native theme drawing code actually draws the blue strip, but
it draws it inside the content area, which then gets hidden by the actual content.

Attaching screenshot.

I'm wondering if we could do something like making the tabstrip's border be 0px,
and then make the tabpanels' top margin and padding be -4px and 4 px
respectively. Though, I don't like that hardcoded 4px. cc'ing bryner for ideas.

Comment 7

[jag (Peter Annema)]

Attachment: Screen shot of tab bar blue line

Comment 8

[shliang]

Comment on attachment 123024 [details] [diff] [review]
patch

wait that's not right...

Comment 9

[Kevin Gerich]

Remember the tabs can also be Graphite so a hardcoded blue bar might look silly.
When trying to achive this effect for Pinstripe I found I could expose the tab
panel's blue bar but I didn't figure out how to hide it when the tab strip was
hidden.

Comment 10

[shliang]

Attachment: patch

Comment 11

[shliang]

Attachment: screenshot

Comment 12

[jag (Peter Annema)]

Comment on attachment 123143 [details] [diff] [review]
patch

Talked to Shuehan, the 0px bottom padding and border can be removed from
.tabbrowser-strip.

sr=jag

Comment 13

[Jan Varga [:janv]]

Comment on attachment 123143 [details] [diff] [review]
patch

r=varga

Comment 14

[(not reading, please use [e-mail] instead)]

Comment on attachment 123143 [details] [diff] [review]
patch

assuming this is well tested, a=sspitzer

Comment 15

[shliang]

checked in

Comment 16

[Greg K.]

*** Bug 183609 has been marked as a duplicate of this bug. ***

Comment 17

[Greg K.]

Does this also fix the testcase attachment 108278 [details] on bug 183609?

Comment 18

[Warren TenBrook]

Looks like its time to dup my Bug 154404.

Comment 19

[Greg K.]

Turns out this fixed the tabbrowser bar, but not those of regular XUL tabboxes
as described in my bug 183609. I reopened that bug.

Comment 20

[Grace Bush]

verified build 2003051903