Closed
Bug 1920367
Opened 1 year ago
Closed 1 year ago
Remove use of nsIAtomService from DOMi
Categories
(SeaMonkey :: General, enhancement)
Tracking
(seamonkey2.53+ fixed)
RESOLVED
FIXED
seamonkey2.53
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.20)
Attachments
(1 file)
|
5.38 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
According to bug 1393298 get{Row,Cell} Properties were removed in Gecko 22 so for those prototypes Properties will always be null and the nsIAtomService code is never called. Let's remove the unused argument and code.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
Attachment #9426360 -
Flags: review?(frgrahl)
Attachment #9426360 -
Flags: approval-comm-release?
|
||
Comment 2•1 year ago
|
||
Comment on attachment 9426360 [details] [diff] [review]
1920367-domi-remove-atomservice-25320.patch
LGTM
Attachment #9426360 -
Flags: review?(frgrahl)
Attachment #9426360 -
Flags: review+
Attachment #9426360 -
Flags: approval-comm-release?
Attachment #9426360 -
Flags: approval-comm-release+
|
|
||
Updated•1 year ago
|
Type: task → enhancement
status-seamonkey2.53:
--- → affected
tracking-seamonkey2.53:
--- → ?
Whiteboard: SM2.53.20
|
|
||
Comment 3•1 year ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/d2d98ea0697883d766cac63c41e7fc605bef030a
Remove use of nsIAtomService from DOMi. r=frg a=frg
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.53
Version: Trunk → SeaMonkey 2.53 Branch
|
||
Updated•9 months ago
|
Version: SeaMonkey 2.53 Branch → SeaMonkey 2.53
You need to log in
before you can comment on or make changes to this bug.
Description
•