Closed
Bug 1920531
Opened 4 months ago
Closed 4 months ago
Remove html, json and prettier plugin dependencies from eslint-plugin-mozilla
Categories
(Developer Infrastructure :: Lint and Formatting, task, P3)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox132 fixed)
RESOLVED
FIXED
132 Branch
Tracking | Status | |
---|---|---|
firefox132 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
Separating this out from bug 1917529. For a few modules that are included as peer dependencies in eslint-plugin-mozilla, they seem unnecessary as:
- The html plugin is used as a parser and is only required if a project is parsing html.
- Similary, we use the recommended config for the JSON parser, and it only applies for JSON files.
- The prettier option is only required if a project wants to use prettier. Whilst I think we should have prettier for all Mozilla projects, I don't think we need to enforce/require it here.
Assignee | ||
Comment 1•4 months ago
|
||
Requiring these in eslint-plugin-mozilla seems a bit unnecessary:
- The html plugin is used as a parser and is only required if a project is parsing html.
- Similary, we use the recommended config for the JSON parser, and it only applies for JSON files.
- The prettier option is only required if a project wants to use prettier. Whilst I think we should have prettier for all Mozilla projects, I don't think we need to enforce/require it here.
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/df73766cfce5
Remove html, json and prettier plugin dependencies from eslint-plugin-mozilla. r=frontend-codestyle-reviewers,Gijs
Comment 3•4 months ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
status-firefox132:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•