1927798 - ./mach eslint no longer applies the `curly` rule by default

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect, P2)

Description

[Erik Nordin [:nordzilla]]

Description

I noticed recently that curly braces are not being enforced by ESLint in tree.

I used git bisect and I believe that Bug 1920531 regressed this behavior.

Steps to reproduce

1. Create a test file example.js in the root of the mozilla-unified tree.

/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at https://mozilla.org/MPL/2.0/. */

let x = 0;
if (x === 0) true;

---

2. Run ./mach eslint --fix example.js

---

Expected Behavior
✖ 0 problems (0 errors, 0 warnings, 2 fixed)

--- a/before
+++ b/after
@@ -3,5 +3,7 @@
  * file, You can obtain one at https://mozilla.org/MPL/2.0/. */

 let x = 0;
-if (x === 0) true;
+if (x === 0) {
+  true;
+}

Actual Behavior
✖ 0 problems (0 errors, 0 warnings, 0 fixed)

---

3. Run ./mach eslint --fix example.js --rule "curly:error".
   The file is fixed as expected when manually adding --rule "curly:error".

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1920531

:standard8, since you are the author of the regressor, bug 1920531, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1927798 - Re-enable the curly rule for ESLint. r?#frontend-codestyle-reviewers!

This was accidentally disabled in bug 1920531 with the re-organisation of how eslint-plugin-mozilla worked.
The rule needs to be (re)enabled after eslint-config-prettier is applied, as eslint-config-prettier turns it off by default.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99e4075782cd
Re-enable the curly rule for ESLint. r=frontend-codestyle-reviewers,mossop

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/99e4075782cd

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:standard8, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox133 to wontfix.

For more information, please visit BugBot documentation.