Open
Bug 1920674
Opened 26 days ago
Updated 15 hours ago
Allow rendering an SVG image as the taskbar overlay icon.
Categories
(Core :: Widget: Win32, enhancement, P3)
Core
Widget: Win32
Tracking
()
REOPENED
People
(Reporter: mossop, Assigned: mossop, NeedInfo)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fidefe-profile-management])
Crash Data
Attachments
(2 files)
No description provided.
|
||
Updated•26 days ago
|
|
||
Updated•25 days ago
|
Severity: -- → S3
Priority: -- → P3
|
Assignee | |
Comment 1•24 days ago
|
||
|
||
Updated•9 days ago
|
Attachment #9427135 -
Attachment description: Bug 1920674: Allow rendering an SVG image as the taskbar overlay icon. r=cmartin! → Bug 1920674: Support SVG images in `nsWindowGfx::CreateIcon`. r=rkraesig!
|
|
Assignee | |
Comment 2•9 days ago
|
||
Pushed by dtownsend@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a1dac924abab
Support SVG images in `nsWindowGfx::CreateIcon`. r=win-reviewers,rkraesig
https://hg.mozilla.org/integration/autoland/rev/bd830a73c821
Allow showing the profile avatar in the taskbar on Windows. r=rkraesig,win-reviewers
Backed out for causing gtest failures in TestWindowGfx.CreateIcon_SVG_Context.
- Backout link
- Push with failures
- Failure Log
- Failure line:
[task 2024-10-17T08:34:11.964Z] 08:34:11 INFO - TEST-PASS | TestWindowGfx.CreateIcon_SVG_NoIntrinsic | test completed (time: 5ms)
[task 2024-10-17T08:34:11.964Z] 08:34:11 INFO - TEST-START | TestWindowGfx.CreateIcon_SVG_Context
[task 2024-10-17T08:34:11.967Z] 08:34:11 INFO - [Parent 2852, Main Thread] WARNING: '!manager || !manager->CanSend()', file /builds/worker/checkouts/gecko/gfx/layers/ipc/SharedSurfacesChild.cpp:177
[task 2024-10-17T08:34:11.971Z] 08:34:11 WARNING - TEST-UNEXPECTED-FAIL | TestWindowGfx.CreateIcon_SVG_Context | Expected equality of these values:
[task 2024-10-17T08:34:11.971Z] 08:34:11 INFO - redCount
[task 2024-10-17T08:34:11.971Z] 08:34:11 INFO - Which is: 76.462745098056644
[task 2024-10-17T08:34:11.971Z] 08:34:11 INFO - 0.0
[task 2024-10-17T08:34:11.971Z] 08:34:11 INFO - Which is: 0
[task 2024-10-17T08:34:11.972Z] 08:34:11 INFO - @ /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp:421
[task 2024-10-17T08:34:11.972Z] 08:34:11 WARNING - TEST-UNEXPECTED-FAIL | TestWindowGfx.CreateIcon_SVG_Context | test completed (time: 6ms)
————————————————————————————
- Push with failures
- Failure Log
- Failure line:
[task 2024-10-17T09:07:48.043Z] 09:07:48 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(118,17): error: use of undeclared identifier 'Base64Encode'
[task 2024-10-17T09:07:48.044Z] 09:07:48 INFO - 118 | nsresult rv = Base64Encode(aData, strlen(aData), svgUri);
[task 2024-10-17T09:07:48.044Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.044Z] 09:07:48 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(126,38): error: use of undeclared identifier 'SystemPrincipal'
[task 2024-10-17T09:07:48.045Z] 09:07:48 INFO - 126 | nsCOMPtr<nsIPrincipal> principal = SystemPrincipal::Get();
[task 2024-10-17T09:07:48.045Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.045Z] 09:07:48 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(136,7): error: no viable conversion from 'nsCOMPtr<nsIChannel>' to 'nsIRequest *'
[task 2024-10-17T09:07:48.045Z] 09:07:48 INFO - 136 | channel, tracker, nsCString(IMAGE_SVG_XML), uri, false, 0);
[task 2024-10-17T09:07:48.045Z] 09:07:48 INFO - | ^~~~~~~
[task 2024-10-17T09:07:48.046Z] 09:07:48 INFO - /builds/worker/workspace/obj-build/dist/include/nsCOMPtr.h(759,3): note: candidate function
[task 2024-10-17T09:07:48.046Z] 09:07:48 INFO - 759 | operator T*() const& { return get(); }
[task 2024-10-17T09:07:48.046Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.047Z] 09:07:48 INFO - /builds/worker/workspace/obj-build/dist/include/nsCOMPtr.h(764,3): note: candidate function not viable: expects an rvalue for object argument
[task 2024-10-17T09:07:48.047Z] 09:07:48 INFO - 764 | operator T*() const&& = delete;
[task 2024-10-17T09:07:48.047Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.047Z] 09:07:48 INFO - /builds/worker/checkouts/gecko/image/ImageFactory.h(42,58): note: passing argument to parameter 'aRequest' here
[task 2024-10-17T09:07:48.048Z] 09:07:48 INFO - 42 | static already_AddRefed<Image> CreateImage(nsIRequest* aRequest,
[task 2024-10-17T09:07:48.049Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.050Z] 09:07:48 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(140,15): error: member access into incomplete type 'nsIChannel'
[task 2024-10-17T09:07:48.050Z] 09:07:48 INFO - 140 | rv = channel->Open(getter_AddRefs(stream));
[task 2024-10-17T09:07:48.050Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.050Z] 09:07:48 INFO - /builds/worker/workspace/obj-build/dist/include/nsIAboutModule.h(19,7): note: forward declaration of 'nsIChannel'
[task 2024-10-17T09:07:48.050Z] 09:07:48 INFO - 19 | class nsIChannel; /* forward declaration */
[task 2024-10-17T09:07:48.050Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.050Z] 09:07:48 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(148,36): error: no viable conversion from 'nsCOMPtr<nsIChannel>' to 'nsIRequest *'
[task 2024-10-17T09:07:48.050Z] 09:07:48 INFO - 148 | rv = image->OnImageDataAvailable(channel, stream, 0, size);
[task 2024-10-17T09:07:48.050Z] 09:07:48 INFO - | ^~~~~~~
[task 2024-10-17T09:07:48.050Z] 09:07:48 INFO - /builds/worker/workspace/obj-build/dist/include/nsCOMPtr.h(759,3): note: candidate function
[task 2024-10-17T09:07:48.050Z] 09:07:48 INFO - 759 | operator T*() const& { return get(); }
[task 2024-10-17T09:07:48.050Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.050Z] 09:07:48 INFO - /builds/worker/workspace/obj-build/dist/include/nsCOMPtr.h(764,3): note: candidate function not viable: expects an rvalue for object argument
[task 2024-10-17T09:07:48.051Z] 09:07:48 INFO - 764 | operator T*() const&& = delete;
[task 2024-10-17T09:07:48.051Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.051Z] 09:07:48 INFO - /builds/worker/checkouts/gecko/image/Image.h(245,53): note: passing argument to parameter 'aRequest' here
[task 2024-10-17T09:07:48.052Z] 09:07:48 INFO - 245 | virtual nsresult OnImageDataAvailable(nsIRequest* aRequest,
[task 2024-10-17T09:07:48.052Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.053Z] 09:07:48 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(152,35): error: no viable conversion from 'nsCOMPtr<nsIChannel>' to 'nsIRequest *'
[task 2024-10-17T09:07:48.053Z] 09:07:48 INFO - 152 | rv = image->OnImageDataComplete(channel, NS_OK, true);
[task 2024-10-17T09:07:48.054Z] 09:07:48 INFO - | ^~~~~~~
[task 2024-10-17T09:07:48.055Z] 09:07:48 INFO - /builds/worker/workspace/obj-build/dist/include/nsCOMPtr.h(759,3): note: candidate function
[task 2024-10-17T09:07:48.055Z] 09:07:48 INFO - 759 | operator T*() const& { return get(); }
[task 2024-10-17T09:07:48.056Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.056Z] 09:07:48 INFO - /builds/worker/workspace/obj-build/dist/include/nsCOMPtr.h(764,3): note: candidate function not viable: expects an rvalue for object argument
[task 2024-10-17T09:07:48.057Z] 09:07:48 INFO - 764 | operator T*() const&& = delete;
[task 2024-10-17T09:07:48.057Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.058Z] 09:07:48 INFO - /builds/worker/checkouts/gecko/image/Image.h(257,52): note: passing argument to parameter 'aRequest' here
[task 2024-10-17T09:07:48.059Z] 09:07:48 INFO - 257 | virtual nsresult OnImageDataComplete(nsIRequest* aRequest, nsresult aStatus,
[task 2024-10-17T09:07:48.059Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.059Z] 09:07:48 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(158,7): error: use of undeclared identifier 'SpinEventLoopUntil'; did you mean 'mozilla::SpinEventLoopUntil'?
[task 2024-10-17T09:07:48.060Z] 09:07:48 INFO - 158 | SpinEventLoopUntil("windows:widget:TEST(TestWindowGfx, CreateIcon)"_ns,
[task 2024-10-17T09:07:48.060Z] 09:07:48 INFO - | ^~~~~~~~~~~~~~~~~~
[task 2024-10-17T09:07:48.061Z] 09:07:48 INFO - | mozilla::SpinEventLoopUntil
[task 2024-10-17T09:07:48.061Z] 09:07:48 INFO - /builds/worker/workspace/obj-build/dist/include/mozilla/Assertions.h(657,20): note: expanded from macro 'MOZ_ALWAYS_TRUE'
[task 2024-10-17T09:07:48.061Z] 09:07:48 INFO - 657 | if (MOZ_LIKELY(expr)) { \
[task 2024-10-17T09:07:48.061Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.061Z] 09:07:48 INFO - /builds/worker/workspace/obj-build/dist/include/mozilla/Likely.h(16,46): note: expanded from macro 'MOZ_LIKELY'
[task 2024-10-17T09:07:48.061Z] 09:07:48 INFO - 16 | # define MOZ_LIKELY(x) (__builtin_expect(!!(x), 1))
[task 2024-10-17T09:07:48.061Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.061Z] 09:07:48 INFO - /builds/worker/workspace/obj-build/dist/include/mozilla/SpinEventLoopUntil.h(156,6): note: 'mozilla::SpinEventLoopUntil' declared here
[task 2024-10-17T09:07:48.061Z] 09:07:48 INFO - 156 | bool SpinEventLoopUntil(const nsACString& aVeryGoodReasonToDoThis,
[task 2024-10-17T09:07:48.061Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.061Z] 09:07:48 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(182,23): error: expected ';' after expression
[task 2024-10-17T09:07:48.061Z] 09:07:48 INFO - 182 | UniquePtr<uint8_t[]> bitmapData(new uint8_t[dataLength]);
[task 2024-10-17T09:07:48.061Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.061Z] 09:07:48 INFO - | ;
[task 2024-10-17T09:07:48.061Z] 09:07:48 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(182,3): error: use of undeclared identifier 'UniquePtr'
[task 2024-10-17T09:07:48.061Z] 09:07:48 INFO - 182 | UniquePtr<uint8_t[]> bitmapData(new uint8_t[dataLength]);
[task 2024-10-17T09:07:48.061Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.061Z] 09:07:48 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(182,24): error: use of undeclared identifier 'bitmapData'
[task 2024-10-17T09:07:48.062Z] 09:07:48 INFO - 182 | UniquePtr<uint8_t[]> bitmapData(new uint8_t[dataLength]);
[task 2024-10-17T09:07:48.062Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.062Z] 09:07:48 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(190,24): error: use of undeclared identifier 'bitmapData'
[task 2024-10-17T09:07:48.062Z] 09:07:48 INFO - 190 | (void*)bitmapData.get(), (BITMAPINFO*)&bi, DIB_RGB_COLORS);
[task 2024-10-17T09:07:48.062Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.062Z] 09:07:48 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(200,21): error: use of undeclared identifier 'bitmapData'
[task 2024-10-17T09:07:48.062Z] 09:07:48 INFO - 200 | double blue = bitmapData[index++] / 255.0;
[task 2024-10-17T09:07:48.062Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.062Z] 09:07:48 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(201,22): error: use of undeclared identifier 'bitmapData'
[task 2024-10-17T09:07:48.062Z] 09:07:48 INFO - 201 | double green = bitmapData[index++] / 255.0;
[task 2024-10-17T09:07:48.062Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.062Z] 09:07:48 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(202,20): error: use of undeclared identifier 'bitmapData'
[task 2024-10-17T09:07:48.062Z] 09:07:48 INFO - 202 | double red = bitmapData[index++] / 255.0;
[task 2024-10-17T09:07:48.062Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.062Z] 09:07:48 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(203,22): error: use of undeclared identifier 'bitmapData'
[task 2024-10-17T09:07:48.062Z] 09:07:48 INFO - 203 | double alpha = bitmapData[index++] / 255.0;
[task 2024-10-17T09:07:48.062Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.062Z] 09:07:48 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(220,54): error: use of undeclared identifier 'LayoutDeviceIntPoint'; did you mean 'mozilla::LayoutDeviceIntPoint'?
[task 2024-10-17T09:07:48.062Z] 09:07:48 INFO - 220 | nsWindowGfx::CreateIcon(image, nullptr, false, LayoutDeviceIntPoint(),
[task 2024-10-17T09:07:48.062Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.062Z] 09:07:48 INFO - /builds/worker/workspace/obj-build/dist/include/Units.h(91,47): note: 'mozilla::LayoutDeviceIntPoint' declared here
[task 2024-10-17T09:07:48.062Z] 09:07:48 INFO - 91 | typedef gfx::IntPointTyped<LayoutDevicePixel> LayoutDeviceIntPoint;
[task 2024-10-17T09:07:48.063Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.063Z] 09:07:48 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(221,31): error: use of undeclared identifier 'LayoutDeviceIntSize'
[task 2024-10-17T09:07:48.063Z] 09:07:48 INFO - 221 | LayoutDeviceIntSize(50, 50), &icon);
[task 2024-10-17T09:07:48.063Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.063Z] 09:07:48 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(260,54): error: use of undeclared identifier 'LayoutDeviceIntPoint'; did you mean 'mozilla::LayoutDeviceIntPoint'?
[task 2024-10-17T09:07:48.063Z] 09:07:48 INFO - 260 | nsWindowGfx::CreateIcon(image, nullptr, false, LayoutDeviceIntPoint(),
[task 2024-10-17T09:07:48.063Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.063Z] 09:07:48 INFO - /builds/worker/workspace/obj-build/dist/include/Units.h(91,47): note: 'mozilla::LayoutDeviceIntPoint' declared here
[task 2024-10-17T09:07:48.063Z] 09:07:48 INFO - 91 | typedef gfx::IntPointTyped<LayoutDevicePixel> LayoutDeviceIntPoint;
[task 2024-10-17T09:07:48.063Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.063Z] 09:07:48 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(261,31): error: use of undeclared identifier 'LayoutDeviceIntSize'
[task 2024-10-17T09:07:48.063Z] 09:07:48 INFO - 261 | LayoutDeviceIntSize(200, 200), &icon);
[task 2024-10-17T09:07:48.063Z] 09:07:48 INFO - | ^
[task 2024-10-17T09:07:48.063Z] 09:07:48 INFO - fatal error: too many errors emitted, stopping now [-ferror-limit=]
[task 2024-10-17T09:07:48.063Z] 09:07:48 INFO - 20 errors generated.
[task 2024-10-17T09:07:48.063Z] 09:07:48 ERROR - gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:676: TestWindowGfx.obj] Error 1
[task 2024-10-17T09:07:48.063Z] 09:07:48 INFO - gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/widget/windows/tests/gtest'
[task 2024-10-17T09:07:48.063Z] 09:07:48 INFO - gmake[4]: Target 'target-objects' not remade because of errors.
[task 2024-10-17T09:07:48.063Z] 09:07:48 ERROR - gmake[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: widget/windows/tests/gtest/target-objects] Error 2
[task 2024-10-17T09:07:48.067Z] 09:07:48 INFO - gmake[4]: Entering directory '/builds/worker/workspace/obj-build/mozglue/build'
[task 2024-10-17T09:07:48.068Z] 09:07:48 INFO - gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/mozglue/build'
[task 2024-10-17T09:07:48.103Z] 09:07:48 INFO - gmake[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/xre/dllservices/tests/gtest/TestDllBlocklist_UtilityProcessOnly'
[task 2024-10-17T09:07:48.104Z] 09:07:48 INFO - /builds/worker/.mozbuild/srcdirs/gecko-8a5b87fe5d69/_virtualenvs/build/bin/python /builds/worker/checkouts/gecko/config/create_rc.py 'TestDllBlocklist_UtilityProcessOnly.dll' ''
[task 2024-10-17T09:07:48.104Z] 09:07:48 INFO - gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/xre/dllservices/tests/gtest/TestDllBlocklist_UtilityProcessOnly'
[task 2024-10-17T09:07:48.105Z] 09:07:48 INFO - gmake[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/xre/dllservices/tests/gtest/TestDllBlocklist_UtilityProcessOnly'
[task 2024-10-17T09:07:48.106Z] 09:07:48 INFO - gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/xre/dllservices/tests/gtest/TestDllBlocklist_UtilityProcessOnly'
[task 2024-10-17T09:07:48.111Z] 09:07:48 INFO - gmake[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/xre/dllservices/tests/gtest/TestDllBlocklist_UtilityProcessOnly'
[task 2024-10-17T09:07:48.112Z] 09:07:48 INFO - toolkit/xre/dllservices/tests/gtest/TestDllBlocklist_UtilityProcessOnly/TestDllBlocklist_UtilityProcessOnly.dll.res
[task 2024-10-17T09:07:48.112Z] 09:07:48 INFO - gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/xre/dllservices/tests/gtest/TestDllBlocklist_UtilityProcessOnly'
[task 2024-10-17T09:07:48.127Z] 09:07:48 INFO - gmake[4]: Entering directory '/builds/worker/workspace/obj-build/xpcom/tests/gtest'
Flags: needinfo?(dtownsend)
Pushed by dtownsend@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/624f0ded73c2
Support SVG images in `nsWindowGfx::CreateIcon`. r=win-reviewers,rkraesig
https://hg.mozilla.org/integration/autoland/rev/a309456ce958
Allow showing the profile avatar in the taskbar on Windows. r=rkraesig,win-reviewers
|
||
Comment 6•2 days ago
|
||
Backed out for causing bp-nu bustages on TestWindowGfx.cpp
[task 2024-10-18T10:06:32.500Z] 10:06:32 INFO - gmake[4]: Entering directory '/builds/worker/workspace/obj-build/widget/windows/tests/gtest'
[task 2024-10-18T10:06:32.502Z] 10:06:32 INFO - /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang-cl -fms-compatibility-version=19.39 -std:c++17 -Xclang -ivfsoverlay -Xclang /builds/worker/fetches/vs/overlay.yaml -FoTestWindowGfx.obj -c -I/builds/worker/workspace/obj-build/dist/stl_wrappers -guard:cf -DNDEBUG=1 -DTRIMMED=1 -DUNICODE -D_UNICODE -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -D_SECURE_ATL -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DWIN32 -D_WIN32 -D_WINDOWS -DWIN32_LEAN_AND_MEAN -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DMOZ_SUPPORT_LEAKCHECKING -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/widget/windows/tests/gtest -I/builds/worker/workspace/obj-build/widget/windows/tests/gtest -I/builds/worker/checkouts/gecko/gfx/cairo/cairo/src -I/builds/worker/checkouts/gecko/image -I/builds/worker/checkouts/gecko/widget -I/builds/worker/checkouts/gecko/widget/windows -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -MD -DMOZILLA_CLIENT -FI /builds/worker/workspace/obj-build/mozilla-config.h -Zc:sizedDealloc- -Gy -Zc:inline -Gw -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -TP -GR- -D_HAS_EXCEPTIONS=0 -fcrash-diagnostics-dir=/builds/worker/artifacts -Z7 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -Oy- -Werror -W3 -Wbitfield-enum-conversion -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtautological-constant-in-range-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wenum-compare-conditional -Wenum-float-conversion -Wvolatile -Wno-deprecated-anon-enum-enum-conversion -Wno-deprecated-enum-enum-conversion -Wno-deprecated-this-capture -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-microsoft-enum-value -Wno-microsoft-include -Wno-invalid-noreturn -Wno-inconsistent-missing-override -Wno-implicit-exception-spec-mismatch -Wno-microsoft-exception-spec -Wno-unused-local-typedef -Wno-ignored-attributes -Wno-used-but-marked-unused -Wno-psabi -Wthread-safety -Wno-error=builtin-macro-redefined -Wno-vla-cxx-extension -Wno-unknown-warning-option -fno-strict-aliasing -Xclang -ffp-contract=off -Xclang -MP -Xclang -dependency-file -Xclang .deps/TestWindowGfx.obj.pp -Xclang -MT -Xclang TestWindowGfx.obj /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp
[task 2024-10-18T10:06:32.503Z] 10:06:32 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(118,17): error: use of undeclared identifier 'Base64Encode'
[task 2024-10-18T10:06:32.503Z] 10:06:32 INFO - 118 | nsresult rv = Base64Encode(aData, strlen(aData), svgUri);
[task 2024-10-18T10:06:32.503Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.504Z] 10:06:32 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(126,38): error: use of undeclared identifier 'SystemPrincipal'
[task 2024-10-18T10:06:32.504Z] 10:06:32 INFO - 126 | nsCOMPtr<nsIPrincipal> principal = SystemPrincipal::Get();
[task 2024-10-18T10:06:32.504Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.505Z] 10:06:32 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(136,7): error: no viable conversion from 'nsCOMPtr<nsIChannel>' to 'nsIRequest *'
[task 2024-10-18T10:06:32.505Z] 10:06:32 INFO - 136 | channel, tracker, nsCString(IMAGE_SVG_XML), uri, false, 0);
[task 2024-10-18T10:06:32.505Z] 10:06:32 INFO - | ^~~~~~~
[task 2024-10-18T10:06:32.505Z] 10:06:32 INFO - /builds/worker/workspace/obj-build/dist/include/nsCOMPtr.h(759,3): note: candidate function
[task 2024-10-18T10:06:32.506Z] 10:06:32 INFO - 759 | operator T*() const& { return get(); }
[task 2024-10-18T10:06:32.506Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.506Z] 10:06:32 INFO - /builds/worker/workspace/obj-build/dist/include/nsCOMPtr.h(764,3): note: candidate function not viable: expects an rvalue for object argument
[task 2024-10-18T10:06:32.507Z] 10:06:32 INFO - 764 | operator T*() const&& = delete;
[task 2024-10-18T10:06:32.507Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.508Z] 10:06:32 INFO - /builds/worker/checkouts/gecko/image/ImageFactory.h(42,58): note: passing argument to parameter 'aRequest' here
[task 2024-10-18T10:06:32.508Z] 10:06:32 INFO - 42 | static already_AddRefed<Image> CreateImage(nsIRequest* aRequest,
[task 2024-10-18T10:06:32.508Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.508Z] 10:06:32 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(140,15): error: member access into incomplete type 'nsIChannel'
[task 2024-10-18T10:06:32.508Z] 10:06:32 INFO - 140 | rv = channel->Open(getter_AddRefs(stream));
[task 2024-10-18T10:06:32.509Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.509Z] 10:06:32 INFO - /builds/worker/workspace/obj-build/dist/include/nsIAboutModule.h(19,7): note: forward declaration of 'nsIChannel'
[task 2024-10-18T10:06:32.509Z] 10:06:32 INFO - 19 | class nsIChannel; /* forward declaration */
[task 2024-10-18T10:06:32.509Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.509Z] 10:06:32 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(148,36): error: no viable conversion from 'nsCOMPtr<nsIChannel>' to 'nsIRequest *'
[task 2024-10-18T10:06:32.509Z] 10:06:32 INFO - 148 | rv = image->OnImageDataAvailable(channel, stream, 0, size);
[task 2024-10-18T10:06:32.510Z] 10:06:32 INFO - | ^~~~~~~
[task 2024-10-18T10:06:32.510Z] 10:06:32 INFO - /builds/worker/workspace/obj-build/dist/include/nsCOMPtr.h(759,3): note: candidate function
[task 2024-10-18T10:06:32.510Z] 10:06:32 INFO - 759 | operator T*() const& { return get(); }
[task 2024-10-18T10:06:32.510Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.511Z] 10:06:32 INFO - /builds/worker/workspace/obj-build/dist/include/nsCOMPtr.h(764,3): note: candidate function not viable: expects an rvalue for object argument
[task 2024-10-18T10:06:32.511Z] 10:06:32 INFO - 764 | operator T*() const&& = delete;
[task 2024-10-18T10:06:32.511Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.511Z] 10:06:32 INFO - /builds/worker/checkouts/gecko/image/Image.h(245,53): note: passing argument to parameter 'aRequest' here
[task 2024-10-18T10:06:32.512Z] 10:06:32 INFO - 245 | virtual nsresult OnImageDataAvailable(nsIRequest* aRequest,
[task 2024-10-18T10:06:32.512Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.512Z] 10:06:32 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(152,35): error: no viable conversion from 'nsCOMPtr<nsIChannel>' to 'nsIRequest *'
[task 2024-10-18T10:06:32.512Z] 10:06:32 INFO - 152 | rv = image->OnImageDataComplete(channel, NS_OK, true);
[task 2024-10-18T10:06:32.512Z] 10:06:32 INFO - | ^~~~~~~
[task 2024-10-18T10:06:32.513Z] 10:06:32 INFO - /builds/worker/workspace/obj-build/dist/include/nsCOMPtr.h(759,3): note: candidate function
[task 2024-10-18T10:06:32.513Z] 10:06:32 INFO - 759 | operator T*() const& { return get(); }
[task 2024-10-18T10:06:32.513Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.513Z] 10:06:32 INFO - /builds/worker/workspace/obj-build/dist/include/nsCOMPtr.h(764,3): note: candidate function not viable: expects an rvalue for object argument
[task 2024-10-18T10:06:32.520Z] 10:06:32 INFO - 764 | operator T*() const&& = delete;
[task 2024-10-18T10:06:32.520Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.520Z] 10:06:32 INFO - /builds/worker/checkouts/gecko/image/Image.h(257,52): note: passing argument to parameter 'aRequest' here
[task 2024-10-18T10:06:32.520Z] 10:06:32 INFO - 257 | virtual nsresult OnImageDataComplete(nsIRequest* aRequest, nsresult aStatus,
[task 2024-10-18T10:06:32.520Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.520Z] 10:06:32 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(158,7): error: use of undeclared identifier 'SpinEventLoopUntil'; did you mean 'mozilla::SpinEventLoopUntil'?
[task 2024-10-18T10:06:32.521Z] 10:06:32 INFO - 158 | SpinEventLoopUntil("windows:widget:TEST(TestWindowGfx, CreateIcon)"_ns,
[task 2024-10-18T10:06:32.521Z] 10:06:32 INFO - | ^~~~~~~~~~~~~~~~~~
[task 2024-10-18T10:06:32.521Z] 10:06:32 INFO - | mozilla::SpinEventLoopUntil
[task 2024-10-18T10:06:32.521Z] 10:06:32 INFO - /builds/worker/workspace/obj-build/dist/include/mozilla/Assertions.h(657,20): note: expanded from macro 'MOZ_ALWAYS_TRUE'
[task 2024-10-18T10:06:32.521Z] 10:06:32 INFO - 657 | if (MOZ_LIKELY(expr)) { \
[task 2024-10-18T10:06:32.521Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.521Z] 10:06:32 INFO - /builds/worker/workspace/obj-build/dist/include/mozilla/Likely.h(16,46): note: expanded from macro 'MOZ_LIKELY'
[task 2024-10-18T10:06:32.521Z] 10:06:32 INFO - 16 | # define MOZ_LIKELY(x) (__builtin_expect(!!(x), 1))
[task 2024-10-18T10:06:32.521Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.521Z] 10:06:32 INFO - /builds/worker/workspace/obj-build/dist/include/mozilla/SpinEventLoopUntil.h(156,6): note: 'mozilla::SpinEventLoopUntil' declared here
[task 2024-10-18T10:06:32.521Z] 10:06:32 INFO - 156 | bool SpinEventLoopUntil(const nsACString& aVeryGoodReasonToDoThis,
[task 2024-10-18T10:06:32.521Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.521Z] 10:06:32 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(182,23): error: expected ';' after expression
[task 2024-10-18T10:06:32.521Z] 10:06:32 INFO - 182 | UniquePtr<uint8_t[]> bitmapData(new uint8_t[dataLength]);
[task 2024-10-18T10:06:32.521Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.521Z] 10:06:32 INFO - | ;
[task 2024-10-18T10:06:32.521Z] 10:06:32 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(182,3): error: use of undeclared identifier 'UniquePtr'
[task 2024-10-18T10:06:32.521Z] 10:06:32 INFO - 182 | UniquePtr<uint8_t[]> bitmapData(new uint8_t[dataLength]);
[task 2024-10-18T10:06:32.521Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.521Z] 10:06:32 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(182,24): error: use of undeclared identifier 'bitmapData'
[task 2024-10-18T10:06:32.521Z] 10:06:32 INFO - 182 | UniquePtr<uint8_t[]> bitmapData(new uint8_t[dataLength]);
[task 2024-10-18T10:06:32.521Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.521Z] 10:06:32 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(190,24): error: use of undeclared identifier 'bitmapData'
[task 2024-10-18T10:06:32.522Z] 10:06:32 INFO - 190 | (void*)bitmapData.get(), (BITMAPINFO*)&bi, DIB_RGB_COLORS);
[task 2024-10-18T10:06:32.522Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.522Z] 10:06:32 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(200,21): error: use of undeclared identifier 'bitmapData'
[task 2024-10-18T10:06:32.522Z] 10:06:32 INFO - 200 | double blue = bitmapData[index++] / 255.0;
[task 2024-10-18T10:06:32.522Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.522Z] 10:06:32 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(201,22): error: use of undeclared identifier 'bitmapData'
[task 2024-10-18T10:06:32.522Z] 10:06:32 INFO - 201 | double green = bitmapData[index++] / 255.0;
[task 2024-10-18T10:06:32.522Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.522Z] 10:06:32 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(202,20): error: use of undeclared identifier 'bitmapData'
[task 2024-10-18T10:06:32.522Z] 10:06:32 INFO - 202 | double red = bitmapData[index++] / 255.0;
[task 2024-10-18T10:06:32.522Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.523Z] 10:06:32 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(203,22): error: use of undeclared identifier 'bitmapData'
[task 2024-10-18T10:06:32.523Z] 10:06:32 INFO - 203 | double alpha = bitmapData[index++] / 255.0;
[task 2024-10-18T10:06:32.523Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.523Z] 10:06:32 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(220,54): error: use of undeclared identifier 'LayoutDeviceIntPoint'; did you mean 'mozilla::LayoutDeviceIntPoint'?
[task 2024-10-18T10:06:32.523Z] 10:06:32 INFO - 220 | nsWindowGfx::CreateIcon(image, nullptr, false, LayoutDeviceIntPoint(),
[task 2024-10-18T10:06:32.524Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.524Z] 10:06:32 INFO - /builds/worker/workspace/obj-build/dist/include/Units.h(91,47): note: 'mozilla::LayoutDeviceIntPoint' declared here
[task 2024-10-18T10:06:32.524Z] 10:06:32 INFO - 91 | typedef gfx::IntPointTyped<LayoutDevicePixel> LayoutDeviceIntPoint;
[task 2024-10-18T10:06:32.524Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.524Z] 10:06:32 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(221,31): error: use of undeclared identifier 'LayoutDeviceIntSize'
[task 2024-10-18T10:06:32.524Z] 10:06:32 INFO - 221 | LayoutDeviceIntSize(50, 50), &icon);
[task 2024-10-18T10:06:32.524Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.524Z] 10:06:32 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(260,54): error: use of undeclared identifier 'LayoutDeviceIntPoint'; did you mean 'mozilla::LayoutDeviceIntPoint'?
[task 2024-10-18T10:06:32.525Z] 10:06:32 INFO - 260 | nsWindowGfx::CreateIcon(image, nullptr, false, LayoutDeviceIntPoint(),
[task 2024-10-18T10:06:32.525Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.525Z] 10:06:32 INFO - /builds/worker/workspace/obj-build/dist/include/Units.h(91,47): note: 'mozilla::LayoutDeviceIntPoint' declared here
[task 2024-10-18T10:06:32.525Z] 10:06:32 INFO - 91 | typedef gfx::IntPointTyped<LayoutDevicePixel> LayoutDeviceIntPoint;
[task 2024-10-18T10:06:32.525Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.525Z] 10:06:32 ERROR - /builds/worker/checkouts/gecko/widget/windows/tests/gtest/TestWindowGfx.cpp(261,31): error: use of undeclared identifier 'LayoutDeviceIntSize'
[task 2024-10-18T10:06:32.525Z] 10:06:32 INFO - 261 | LayoutDeviceIntSize(200, 200), &icon);
[task 2024-10-18T10:06:32.525Z] 10:06:32 INFO - | ^
[task 2024-10-18T10:06:32.526Z] 10:06:32 INFO - fatal error: too many errors emitted, stopping now [-ferror-limit=]
[task 2024-10-18T10:06:32.526Z] 10:06:32 INFO - 20 errors generated.
[task 2024-10-18T10:06:32.526Z] 10:06:32 ERROR - gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:674: TestWindowGfx.obj] Error 1
[task 2024-10-18T10:06:32.526Z] 10:06:32 INFO - gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/widget/windows/tests/gtest'
[task 2024-10-18T10:06:32.526Z] 10:06:32 INFO - gmake[4]: Target 'target-objects' not remade because of errors.
[task 2024-10-18T10:06:32.526Z] 10:06:32 ERROR - gmake[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: widget/windows/tests/gtest/target-objects] Error 2
Pushed by dtownsend@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ad952b2e4b9c
Support SVG images in `nsWindowGfx::CreateIcon`. r=win-reviewers,rkraesig
https://hg.mozilla.org/integration/autoland/rev/5b0f9712258c
Allow showing the profile avatar in the taskbar on Windows. r=rkraesig,win-reviewers
|
||
Comment 8•1 day ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ad952b2e4b9c
https://hg.mozilla.org/mozilla-central/rev/5b0f9712258c
Status: NEW → RESOLVED
Closed: 1 day ago
status-firefox133:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
|
||
Comment 9•17 hours ago
|
||
Backed out for causing crashes @ nsWindowGfx::Data32BitTo1Bit
Backout link: https://hg.mozilla.org/mozilla-central/rev/46a2094acb5ec0c35a97399e1270e7c868ceae0c
Status: RESOLVED → REOPENED
status-firefox133:
fixed → ---
Resolution: FIXED → ---
Target Milestone: 133 Branch → ---
|
|
||
Updated•17 hours ago
|
Flags: needinfo?(dtownsend)
|
|
||
Updated•17 hours ago
|
Flags: needinfo?(dtownsend)
|
||
Comment 10•15 hours ago
|
||
Crash report example: bp-0d04d30a-e8ff-4700-b477-b3ba60241019
Trigger by tabs which use an SVG as favicon.
Crash Signature: [@ nsWindowGfx::Data32BitTo1Bit]
You need to log in
before you can comment on or make changes to this bug.
Description
•