1920747 - The "hasNew" attribute is not cleared after all messages have been read

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect, P2)

Description

[Alessandro Castellani [:aleca]]

Attachment: Screenshot 2024-09-24 092026.png

STR

• Have a thread with multiple new and unread messages
• Open the thread and read all the messages
• Close the thread

Result:
The # replies button remains blue colored with new star icon.

Upon inspecting the code it looks like the hasNew property is not correctly cleared while the hasUnread is.
The property is cleared after interacting again with the message (expand/collapse or select again).

Comment 1

[Alessandro Castellani [:aleca]]

Attachment: Bug 1920747 - Ensure the hasNew CSS property is only used when also hasUnread is present. r=#thunderbird-front-end-reviewers,Paenglab!

The "hasNew" style of the reply button should be styled consistently
in all instances, and clear out immediately after the last new/unread
message of a thread is touched.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/70bc03aa3289
Ensure the hasNew CSS property is only used when also hasUnread is present. r=Paenglab,micahilbery,vineet

Comment 3

[Corey Bryant]

Is this ready for uplift to beta?

Comment 4

[Alessandro Castellani [:aleca]]

Comment on attachment 9428935 [details]
Bug 1920747 - Ensure the hasNew CSS property is only used when also hasUnread is present. r=#thunderbird-front-end-reviewers,Paenglab!

[Approval Request Comment]
Regression caused by (bug #): -
User impact if declined: The "replies" button in cards view remains temporarily styled as if there are still new messages in the collapsed thread of children
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low, just a simple CSS change

Comment 5

[Corey Bryant]

Comment on attachment 9428935 [details]
Bug 1920747 - Ensure the hasNew CSS property is only used when also hasUnread is present. r=#thunderbird-front-end-reviewers,Paenglab!

[Triage Comment]
Approved for beta

Comment 6

[Corey Bryant]

Thunderbird 132.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/ebe040cd7e00