1920755 - 'interactive-widget' meta viewport key not behaving correctly when showing a virtual keyboard (on Android 10)

Status: VERIFIED FIXED

(GeckoView :: General, defect)

Description

[Dave Letorey]

The interactive-widget property of viewport meta tag is not working as expected.

Tested

Browsers

I have tested this in:

• firefox beta for android v131.01a
• firefox nightly for android v132.06b
• chrome for android v128.0.6613.146

OS & Device

• Android Version - 10
• Device - OnePlus 5
• Model - ONEPLUS A5000

Web Pages tested

Explantion of viewport behaviour
Viewport Resize Behaviour by Bramus

• interactive-widget=resizes-visual
• interactive-widget=resizes-content
• interactive-widget=overlays-content

All works as expected in Chrome for Android but not so in Android. All test screenshots can be found here, along with the about:supports data from Firefox Beta & Nightly.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

I can reproduce the issue on an Android 10 emulator. My best guess is that this code block is something wrong.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1920755 - Return `WindowInsetsCompat.Type.ime()` directly on Android 10. r?#geckoview-reviewers

As far as I tested on an Android emulator 10,
insetsCompat.getInsets(WindowInsetsCompat.Type.ime()).bottom and
insetsCompat.getInsets(WindowInsetsCompat.Type.navigationBars()).bottom are
same, thus subtracting the bavigationBars' bottom will fail to tell the software
keyboard height.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7e0882717cc
Return `WindowInsetsCompat.Type.ime()` directly on Android 10. r=geckoview-reviewers,m_kato

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/c7e0882717cc

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 9427640 [details]
Bug 1920755 - Return WindowInsetsCompat.Type.ime() directly on Android 10. r?#geckoview-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Users on Android 10 devices will keep suffering from webcompat issues fixed by the default interactive-widget mode (bug 1916002)
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change is pretty simple, and only affects on Android 10 devices
• String changes made/needed: none
• Is Android affected?: Yes

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9427640 [details]
Bug 1920755 - Return WindowInsetsCompat.Type.ime() directly on Android 10. r?#geckoview-reviewers

Approved for 132.0b4.

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/6f03ca02fd31

Comment 8

[Dave Letorey]

Related issues and pull requests

• Content PR
• Firefox release PR

Comment 9

[Vasilica Tamas QA [:vtamas]]

Confirming that all 3 scenarios are rendered as expected on Firefox 136 (2025-01-21), Firefox 135 beta 7 and Firefox 134.0.2 using Galaxy S24 Ultra (Android 14) and Oneplus 6T (Android 11).

Comment 10

[Vasilica Tamas QA [:vtamas]]

Attachment: resizes-visual.JPEG

Comment 11

[Vasilica Tamas QA [:vtamas]]

Attachment: resizes-content.JPEG

Comment 12

[Vasilica Tamas QA [:vtamas]]

Attachment: overlays-content.JPEG