1916002 - Let resizes-visual as the default interactive-widget mode ride the trains

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task, P2)

Description

[Botond Ballo [:botond]]

In bug 1884807, we changed the default interactive-widget mode to resizes-visual on the Nightly channel.

This bug tracks letting that change ride the trains to the release channel.

Comment 1

[Botond Ballo [:botond]]

Given the large number of web compat issues resizes-visual resolves, we'd like to let it ride the trains with the 132 release if no showstopper bugs with it are found during the remainder of the Nightly cycle.

We are not planning to treat the bugs currently in the "Depends on" list (bug 1912008, bug 1915508, bug 1915509) as hard blockers; we'd like to fix these as soon as we can get to them but likely not for 132.

Comment 2

[Botond Ballo [:botond]]

Attachment: Bug 1916002 - Let resizes-visual as the default interactive-widget mode ride the trains. r=hiro

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bbd614a26a6a
Let resizes-visual as the default interactive-widget mode ride the trains. r=hiro

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/bbd614a26a6a

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Sounds like we probably want a relnote nomination for this also?

Comment 6

[Botond Ballo [:botond]]

Release Note Request (optional, but appreciated)
[Why is this notable]:

• It implements part of a new draft spec (CSS Viewport 1)
• It resolves a number of web compat issues affecting popular sites such as AiBnB, Pinterest, Taobao, and others, in Firefox for Android

[Suggested wording]:
Firefox for Android now uses resizes-visual as the default value of the interactive-widget property of the viewport <meta> element. This means that when the software keyboard is shown, Firefox resizes the page's visual viewport but not its layout viewport, avoiding an expensive reflow and resulting in a more usable layout on many pages.

[Links (documentation, blog post, etc)]:
https://developer.chrome.com/blog/viewport-resize-behavior is a pretty good explainer of the feature

Comment 7

[Daniel Holbert [:dholbert]]

Heads-up, I just determined that a bug (bug 1918178) about fixed-position footers -- filed a few weeks back -- is in fact a regression caused by this resizes-visual feature.

We initially thought it was a bug with the new experimental navbar and was hence nightly-only-for-now; but on further investigation in bug 1918178 comment 3, it turns out that the issue over there also affects the non-navbar configuration [the toolbar configuration we're shipping in release], and it seems to have been regressed by the resizes-visual enabling (which we're now shipping to release per this bug). I confirmed that the issue goes away if I turn the resizes_visual pref off in about:config.

So: probably worth getting to the bottom of that bug & seeing what we can do about it, to see if we can avoid shipping that to release users before resizes-visual makes it to the release channel, if possible.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Added to the Fx132 relnotes.