1920799 - Add a new messaging surface to the AppMenu that allows us to try explain what signing into an FxA does

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

See the (still in flux) Figma specification for what the idea is, but basically we want to be able to try a few different messages in the AppMenu for users in the signed-out state to see if we can improve on the existing messaging in the AppMenu regarding FxA and what utility it brings.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1920799 - Add a new messaging surface to the AppMenu and PXI menus for describing the value of signing into an FxA. r?pdahiya!,Gijs!

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Hey pdahiya,

I'm hoping to get some early feedback from you on this patch so far - does the approach seem like the right one, ASRouter-wise? What kind of test coverage is expected of a new surface like this?

Hey skhamis,

I see you've landed patches and reviewed changes going into browser-sync.js, and wanted to get your take on this WIP too. Without going into the depths of a full review, is the approach reasonable for adding this message, and putting most of the logic for creating / managing that message in browser-sync?

If you'd like to see what this looks like, you can apply this patch, and with browser.newtabpage.activity-stream.asrouter.devtoolsEnabled set to true, visit about:asrouter, find the FXA_ACCOUNTS_APPMENU_PROTECT_BROWSING_DATA message and click "Show". The current design, content and illustration are still somewhat in flux, but it's going to (roughly) be like what's in the patch.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

(Hm, those manual testing steps appear to have broken since I last tried them - I'll update the patch shortly. needinfos still stand though! :) )

Comment 4

[Punam Dahiya [:pdahiya]]

Hi Mike, Tried patch and left some early feedback, approach at high level looks great thanks!

Comment 5

[Sammy Khamis [:skhamis]]

Thanks for allowing me to check in on the initial approach! Seems like a reasonable approach and relatively compartmentalized. Definitely excited to see this and providing users some clear messaging!!

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1920799 - Add tests for the new menu messaging surface for the FxA CTA message. r?pdahiya!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e81d1a9c3077
Add a new messaging surface to the AppMenu and PXI menus for describing the value of signing into an FxA. r=pdahiya,Gijs,desktop-theme-reviewers,omc-reviewers,home-newtab-reviewers,fluent-reviewers,hjones,skhamis,nbarrett
https://hg.mozilla.org/integration/autoland/rev/ad12589113c3
Add tests for the new menu messaging surface for the FxA CTA message. r=pdahiya,omc-reviewers,home-newtab-reviewers,nbarrett

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/e81d1a9c3077
https://hg.mozilla.org/mozilla-central/rev/ad12589113c3