Closed Bug 1922594 Opened 1 year ago Closed 1 year ago

Add strings and image assets for AppMenu messaging experiments for 133

Categories

(Firefox :: Messaging System, task, P1)

Product:
Firefox
Component:
Messaging System
Type:
task
Points:
2

Tracking

()

Status:
RESOLVED FIXED
Milestone:
133 Branch
Iteration:
133.2 - Oct 14 - Oct 25
Tracking Flags:
Tracking Status
firefox133 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [fidefe-device-migration])

Attachments

(6 files, 3 obsolete files)

fox-with-box-on-cloud.svg
52.55 KB, image/svg+xml
Details
fox-with-devices.svg
31.77 KB, image/svg+xml
Details
fox-with-locked-box.svg
39.41 KB, image/svg+xml
Details
fox-with-mobile.svg
17.43 KB, image/svg+xml
Details
Bug 1922594 - Add strings for FxA menu messages and the ability to experiment with the sign-in CTA on both panels. r?skhamis!,pdahiya!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1922594 - Add image assets for FxA menu messages. r?pdahiya!
48 bytes, text/x-phabricator-request
Details | Review

Once the strings and images have been sorted for the messages, we should get those in the tree.

See https://www.figma.com/design/az2OjFtxH5tXqEZVrTn30L/Experiments-for-PXI-panel-%2F-App-menu?node-id=212-4862&node-type=rounded_rectangle&m=dev.

Whiteboard: [fidefe-device-migration]
Attached image firefox-vectorized-18.svg (obsolete) —
Attached image firefox-vectorized-19.svg (obsolete) —
Attached image firefox-vectorized-20.svg (obsolete) —
Severity: -- → N/A
Iteration: --- → 133.1 - Sep 30 - Oct 11
Priority: -- → P1
Attachment #9428884 - Attachment is obsolete: true
Attachment #9428886 - Attachment is obsolete: true
Attachment #9428888 - Attachment is obsolete: true

Run through SVGO and added license header.

Attached image fox-with-mobile.svg —

The strings in the Figma have been signed off with, so I'll post these now. For images, we're going to host them on the Remote Settings CDN like we do with other message treatments, so that we don't have to add to the omni.ja size for something ephemeral.

Hey Shane, are images automatically hosted on the CDN automatically preloaded somehow? Or do we run the risk of showing no image / a flicker as the image loads, particularly on slow networks?

Flags: needinfo?(shughes)
Attachment #9429630 - Attachment description: Bug 1922594 - Add strings for FxA AppMenu messages. r?pdahiya! → Bug 1922594 - Add strings for FxA AppMenu messages and the ability to experiment with the sign-in CTA. r?skhamis!
Attachment #9429630 - Attachment description: Bug 1922594 - Add strings for FxA AppMenu messages and the ability to experiment with the sign-in CTA. r?skhamis! → Bug 1922594 - Add strings for FxA menu messages and the ability to experiment with the sign-in CTA on both panels. r?skhamis!
Iteration: 133.1 - Sep 30 - Oct 11 → 133.2 - Oct 14 - Oct 25
Points: --- → 2
Blocks: 1924752
Attachment #9429630 - Attachment description: Bug 1922594 - Add strings for FxA menu messages and the ability to experiment with the sign-in CTA on both panels. r?skhamis! → Bug 1922594 - Add strings for FxA menu messages and the ability to experiment with the sign-in CTA on both panels. r?skhamis!,pdahiya!

This also tweaks some styles for the fxa-menu-message so that we're
more aligned with the Figma specification.

Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9372edf868fe Add strings for FxA menu messages and the ability to experiment with the sign-in CTA on both panels. r=fluent-reviewers,omc-reviewers,skhamis,desktop-theme-reviewers,bolsson,pdahiya,hjones https://hg.mozilla.org/integration/autoland/rev/32bbfcc1607a Add image assets for FxA menu messages. r=pdahiya,omc-reviewers

Backed out for causing bc failures on browser_sync.js

Backout link

Push with failures

Failure log

Flags: needinfo?(mconley)
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5c6c15e0a404 Add strings for FxA menu messages and the ability to experiment with the sign-in CTA on both panels. r=fluent-reviewers,omc-reviewers,skhamis,desktop-theme-reviewers,bolsson,pdahiya,hjones https://hg.mozilla.org/integration/autoland/rev/7faf66788d9b Add image assets for FxA menu messages. r=pdahiya,omc-reviewers

https://hg.mozilla.org/mozilla-central/rev/5c6c15e0a404
https://hg.mozilla.org/mozilla-central/rev/7faf66788d9b

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox133: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
Flags: needinfo?(mconley)
Flags: needinfo?(shughes)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: