1920862 - PiP captions no longer work on sbs.com.au

Status: ASSIGNED

(Toolkit :: Picture-in-Picture, defect, P3)

Description

[Albert Scheiner [:alberts]]

STR:

1. View a video in www.sbs.com.au (example video)
   Note: there is most likely an ad playing before we can continue with step #2
2. Enable captions in the site's video player
3. Enable PiP for the video via the address bar button, toggle over the video, or context menu

Expected:

• captions are displayed on the PiP window

Actual:

• no captions are displayed on the PiP window

Notes:

• It looks like SBS is using VideoJS. Is it just missing the entry in https://searchfox.org/mozilla-central/source/browser/extensions/pictureinpicture/data/picture_in_picture_overrides.js?

Comment 1

[kernp25]

Attachment: Bug 1920862 - Add subtitle support for sbs.com.au. r?#pip-reviewers!

Comment 2

[Albert Scheiner [:alberts]]

Just a follow up on this, as it seems to be waiting on a quick review.

Comment 3

[kpatenio]

Hi kernp25,

Just following up and seeing if you're still around to update the patch. Similar to Bug 1893820, adding the wrapper path to moz.build is no longer needed. Plus, I had a question about a change in the new wrapper.

I recall sometime ago having a hard time accessing videos in sbs.com.au; if that changes for me, and if I don't hear back by next week, I can try picking up the patch from where you left off.

Comment 4

[Albert Scheiner [:alberts]]

kpatenio, I just emailed you a dummy account login, in case the need arises.

Comment 5

[kpatenio]

(In reply to Albert Scheiner [:alberts] from comment #4)

kpatenio, I just emailed you a dummy account login, in case the need arises.

Fantastic, thanks so much! That will help immensely. Since a long weekend is coming up in Canada, I'll pick up the bug by the time I'm back.

Comment 6

[kpatenio]

Attachment: Bug 1920862 - Add subtitle support for sbs.com.au. r?#pip-reviewers!

Comment 7

[BugBot [:suhaib / :marco]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit BugBot documentation.