1921092 - Make Persisted Search with non-default engines consistent with the behavior of default engines

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[James Teow [:jteow]]

• Have Persisted Search Enabled
• Do a search with a non-default engine that is a single page application (e.g. DDG, Qwant)
• On their SERP, click on one of the non-default search tabs (e.g. Images, Maps)

Expected Result

• The terms should no longer persist.

Actual Result

• The search terms persist and the search chiclet still appears.

The reason this happens is because userTypedValue is set when we enter search mode. The existence of userTypedValue then prevents future calls to setURI from entering the code path that would unset the cached search terms.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1913312

Comment 2

[James Teow [:jteow]]

Attachment: Bug 1921092 - Simplify Persisted Search logic and make non-default engines consistent - r?adw!

Depends on D224122

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1913312

Comment 4

[James Teow [:jteow]]

Attachment: Bug 1921092 - Simplify Persisted Search logic and make non-default engines consistent - r?adw!

Comment 5

[James Teow [:jteow]]

Attachment: Bug 1921092 - Simplify Persisted Search logic and make non-default engines consistent - r?adw!

Erroneous patch.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7d9e37ec186
Simplify Persisted Search logic and make non-default engines consistent - r=adw,urlbar-reviewers

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e7d9e37ec186

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jteow, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox132 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[James Teow [:jteow]]

I'm not uplifting it to Firefox 132 because the feature affected is not enabled by default.

Comment 10

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-09-25 Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 133.0a1 on Windows 10, Ubuntu 22, macOS 14.