Closed Bug 1921092 Opened 21 days ago Closed 8 days ago

Make Persisted Search with non-default engines consistent with the behavior of default engines

Categories

(Firefox :: Address Bar, defect, P3)

Product:
Firefox
Component:
Address Bar
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
133 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- unaffected
firefox130 --- unaffected
firefox131 --- unaffected
firefox132 --- wontfix
firefox133 --- fixed

People

(Reporter: jteow, Assigned: jteow)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [sng])

Attachments

(1 file, 2 obsolete files)

Bug 1921092 - Simplify Persisted Search logic and make non-default engines consistent - r?adw!
48 bytes, text/x-phabricator-request
Details | Review
  • Have Persisted Search Enabled
  • Do a search with a non-default engine that is a single page application (e.g. DDG, Qwant)
  • On their SERP, click on one of the non-default search tabs (e.g. Images, Maps)

Expected Result

  • The terms should no longer persist.

Actual Result

  • The search terms persist and the search chiclet still appears.

The reason this happens is because userTypedValue is set when we enter search mode. The existence of userTypedValue then prevents future calls to setURI from entering the code path that would unset the cached search terms.

Set release status flags based on info from the regressing bug 1913312

status-firefox130: --- → unaffected
status-firefox131: --- → unaffected
status-firefox132: --- → affected
status-firefox-esr115: --- → unaffected
status-firefox-esr128: --- → unaffected
Blocks: urlbar-persisted
Summary: Persisted Search with Non-default engines → Make Persisted Search with non-default engines consistent with the behavior of default engines
Assignee: nobody → jteow
Status: NEW → ASSIGNED

Set release status flags based on info from the regressing bug 1913312

status-firefox133: --- → affected
Attachment #9428095 - Attachment is obsolete: true
Attachment #9428911 - Attachment is obsolete: true
Pushed by jteow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e7d9e37ec186 Simplify Persisted Search logic and make non-default engines consistent - r=adw,urlbar-reviewers

https://hg.mozilla.org/mozilla-central/rev/e7d9e37ec186

Status: ASSIGNED → RESOLVED
Closed: 8 days ago
status-firefox133: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch

The patch landed in nightly and beta is affected.
:jteow, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox132 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(jteow)

I'm not uplifting it to Firefox 132 because the feature affected is not enabled by default.

status-firefox132: affected → wontfix
Flags: needinfo?(jteow)
Regressions: 1923374
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: