1927113 - Search mode transfers to other tabs while cycling tabs when persisted search enabled

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Adrian Florinescu [:aflorinescu]]

Attachment: search-mode.mp4

Found in

• 133.0a1 (2024-10-25)

Affected versions

• 133.0a1 (2024-10-25)
• presist search enabled on Nightly/Early beta

Tested platforms

• Affected platforms: Windows 11, Mac 14, Ubuntu 24

Preconditions

• browser.urlbar.showSearchTerms.featureGate set to TRUE (default in Nightly)

Steps to reproduce

1. Open Tab 1 - execute random search with default engine
2. Open Tab2- enter search mode with any engine
3. Cycle tabs back to tab1 - either click or Ctrl+Pgup/Down.

Expected result

• Tab1, Tab2 content doesn't change

Actual result

• The search mode from tab2 applies to tab1

Regression range

• TBD

Additional Notes

• Reproduces with browser.urlbar.scotchBonnet.enableOverride as well.

Comment 1

[Petruta Horea [:phorea], Desktop Test Engineering]

Mozregression points to bug 1921092 as regressor:
DEBUG : Found commit message:
Bug 1921092 - Simplify Persisted Search logic and make non-default engines consistent - r=adw,urlbar-reviewers

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:jteow, since you are the author of the regressor, bug 1921092, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Marco Bonardo [:mak]]

The feature is also enabled in Early Beta releases, not just Nightly.
It should not affect Release, anyway.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1921092

Comment 5

[Donal Meehan [:dmeehan]]

Setting Fx133 to disabled.
The following prefs are disabled in late beta

• pref("browser.urlbar.showSearchTerms.featureGate", true);

Correcting the other tracking flags since the regressor only landed during 133

Comment 6

[James Teow [:jteow]]

Attachment: Bug 1927113 - Ensure persisted search doesn't show search mode from another tab - r?adw!

this.searchMode can return null even if a search mode is shown
in the address bar, as the getter uses the current browser as the
context and attempts to use the state data. I try to solve this
by relying on the fact that a tab switch and invalid pageproxystate
results in restoring the search mode state.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9c8f6767ee2
Ensure persisted search doesn't show search mode from another tab - r=adw,urlbar-reviewers

Comment 8

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/a9c8f6767ee2

Comment 9

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-10-25 Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 134.0a1 on Windows 10, Ubuntu 22, macOS 14.