1921220 - Add settings toggle for Fenix DAU ping

Status: RESOLVED FIXED

(Firefox for Android :: Settings, enhancement, P1)

Description

[:Gijs (he/him)]

For the additional DAU ping we will want a separate settings toggle that controls whether it is uploaded.

When we add this, we must make sure that for any users that have already disabled telemetry, the new ping is also disabled.

Content design for this work has not been finalized so this is not actionable as yet.

Comment 1

[Joe M [:jmahon]]

Adding a link to a Jira clone of this bug simply for task tracking purposes. The majority of conversation should happen here in Bugzilla.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:royang, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Roger Yang [:royang]]

:gijs, this issue seems to be a task. Is this issue a defect? Thanks

Comment 4

[:Gijs (he/him)]

(In reply to Roger Yang [:royang] from comment #3)

:gijs, this issue seems to be a task. Is this issue a defect? Thanks

It's either a defect or enhancement, as the end result is user-visible (unlike tasks). 302 to Polly on her preferences for how to grade this.

Comment 5

[Polly [:polly]]

:D nice 302-ing!
i think it's probably an enhancement, but will not fight anyone who disagrees

Comment 6

[Polly [:polly]]

Jan-Erik has suggested a way forward for this. In summary:
Client apps will need to generate and store a new dau_id for the lifetime of the app.

Steps:

• add a new usage:profile_id metric to fenix/app/metrics.yaml ("the dau id")
• on first launch of the app when Glean is initialised, call Dau.id.generateAndSet() and save the returned usage profile id string in a Preference
• on subsequent launches of the app:
  -- if upload is enabled, retrieve the usage profile id value from the preference and call Dau.id.set(dauId)
  -- if upload is disabled, unset the usage profile id

When the daily usage ping switch is toggled:

• ON: generate and set the usage profile id & store in preference
• OFF: unset the usage profile id

NB unsetting the usage profile id is achieved by setting the UUID to a canary value: Dau.id.set('beefbeef-beef-beef-beef-beeefbeefbee')

Comment 7

[Polly [:polly]]

more detailed description here: https://docs.google.com/document/d/1leZN_CUREyfpT3xzI9-6vU5hw52bOkN0Y4Zr67hjXAE/edit?tab=t.0#heading=h.hk6l07cjhhu
link to desktop version of this logic: https://phabricator.services.mozilla.com/D226766#change-LA3ck9LOHpzu

Comment 8

[Polly [:polly]]

link to new ui designs for settings page now signed off by legal! :tada:
NB the ui designs don't show the "Automatically submit crash reports" switch, which was added recently, but it is intended to be on the screen above the "Studies" link.

Comment 9

[Polly [:polly]]

Attachment: Bug 1921220: add glean usage profile id.

WIP

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c268ce25bdd1
add glean usage profile id. r=android-reviewers,data-stewards,TravisLong,tthibaud

Comment 11

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/c268ce25bdd1

Comment 12

[Polly [:polly]]

reopening because the ping is in but the switch part still needs doing

Comment 13

[Polly [:polly]]

Attachment: data-collection-settings.png

NB the daily usage ping switch and "learn more" link should follow the style of the existing settings on the page. We are adding content, not changing any existing settings styles (some early designs show these somewhat differently to the current ones).
Please see attached mock up.

Comment 14

[Polly [:polly]]

Attachment: data-collection-settings.png

Comment 15

[Polly [:polly]]

Attachment: Bug 1921220: add switch for glean daily usage ping

Comment 16

[Polly [:polly]]

Attachment: Bug 1921220: add more ui & jvm tests for glean daily usage ping switch

Comment 17

[Polly [:polly]]

Attachment: Bug 1921220: move usage profile id into new separate usage reporting service

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c5eeacc3778
add switch for glean daily usage ping r=android-reviewers,tthibaud

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f363ed147d13
add more ui & jvm tests for glean daily usage ping switch r=android-reviewers,tthibaud,sfamisa

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6a0b0495b40
move usage profile id into new separate usage reporting service r=android-reviewers,boek

Comment 21

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3c5eeacc3778
https://hg.mozilla.org/mozilla-central/rev/f363ed147d13
https://hg.mozilla.org/mozilla-central/rev/c6a0b0495b40

Comment 22

[Ryan VanderMeulen [:RyanVM]]

Do we need this on Beta? Please nominate if so.

Comment 23

[Polly [:polly]]

no, i don't think this should go to beta - it's going through QA rn and i think the plan is for a bunch of related stuff to land in 136.
thanks for checking though :)