1921336 - Vertical pinned tabs scrollable area is tab focusable

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect, P1)

Description

[Mark Striemer [:mstriemer]]

When the vertical pinned tabs area is overflowing it is possible to focus the scrollable container (#vertical-pinned-tabs-container). This adds an extra tabstop that isn't very useful since the next tab will jump to whatever tab is selected so scrolling the container doesn't help with anything.

STR

1. Enable vertical tabs
2. With the sidebar collapsed pin 6 or more tabs
3. Focus the address bar (Cmd/Ctrl+L)
4. Tab, Tab, Tab (foc the vertical tabs area)

Expected results: Selected tab is focused
Actual results: The pinned tab container is focused

This should just need a tabindex="-1" to remove it from the tab order.

Comment 1

[Sarah Clements [:sclements]]

Attachment: Bug 1921336 - Remove focus from vertical-pinned-tabs-container r=#tabbrowser-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd20e3bccf40
Remove focus from vertical-pinned-tabs-container r=tabbrowser-reviewers,dao

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/bd20e3bccf40

Comment 4

[Dana Lucaci, Desktop QA]

Reproduced the issue with Firefox 132.0a1 (2024-09-23) on Windows 10.
The issue is verified fixed with Firefox 134.0a1 (20241105092845) and Firefox 133.0b4(20241104091514) on Windows 10, Ubuntu 22 and macOS 14.