Closed Bug 1921336 Opened 4 months ago Closed 4 months ago

Vertical pinned tabs scrollable area is tab focusable

Categories

(Firefox :: Sidebar, defect, P1)

defect

Tracking

()

VERIFIED FIXED
133 Branch
Tracking Status
firefox133 --- fixed

People

(Reporter: mstriemer, Assigned: sclements)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-sidebar])

Attachments

(1 file)

When the vertical pinned tabs area is overflowing it is possible to focus the scrollable container (#vertical-pinned-tabs-container). This adds an extra tabstop that isn't very useful since the next tab will jump to whatever tab is selected so scrolling the container doesn't help with anything.

STR

  1. Enable vertical tabs
  2. With the sidebar collapsed pin 6 or more tabs
  3. Focus the address bar (Cmd/Ctrl+L)
  4. Tab, Tab, Tab (foc the vertical tabs area)

Expected results: Selected tab is focused
Actual results: The pinned tab container is focused

This should just need a tabindex="-1" to remove it from the tab order.

Priority: -- → P1
Severity: -- → S3
Whiteboard: [fidefe-sidebar]
See Also: → 1921953
Assignee: nobody → sclements
Status: NEW → ASSIGNED
Pushed by sclements@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bd20e3bccf40 Remove focus from vertical-pinned-tabs-container r=tabbrowser-reviewers,dao
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
Flags: qe-verify+

Reproduced the issue with Firefox 132.0a1 (2024-09-23) on Windows 10.
The issue is verified fixed with Firefox 134.0a1 (20241105092845) and Firefox 133.0b4(20241104091514) on Windows 10, Ubuntu 22 and macOS 14.

Status: RESOLVED → VERIFIED
Has STR: --- → yes
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: