1921953 - Closing notification banner causes sidebar to steal keyboard focus (thick border outline)

Status: NEW

(Firefox :: Sidebar, defect, P2)

Description

[Kestrel]

Attachment: Sidebar focused after closing notification banner

STR:

1. Start with sidebar.verticalTabs = true and sidebar.revamp = true.
2. Make sure "Play DRM-controlled content" is disabled in settings.
3. Visit https://bitmovin.com/demos/drm.
4. Close the notification banner, "You must enable DRM to play some audio or video on this page".

Expected:
Active tab appearance and keyboard focus does not change, pressing up/down arrow keys scrolls the page.

Actual:
Active tab becomes focused with thick border outline, pressing up/down arrow keys switches tabs.

When vertical tabs are disabled, the sidebar receives focus and pressing up/down moves between buttons.

Comment 1

[Sarah Clements [:sclements]]

I'm not sure this is actually that much of an issue. Anna, what do you think about this?

Comment 2

[Anna Yeddi [:ayeddi]]

(In reply to Sarah Clements [:sclements] from comment #1)

I'm not sure this is actually that much of an issue. Anna, what do you think about this?

I don't think we want to overwrite a default behavior of the page when the sidebar is opened. We do want to allow the sidebar to be focusable when it is open, but not by moving the focus there from a notification, especially when it's closed with a mouse event. With dialogs, for instance, we manage focus or not based on the source of the triggering event (if it's a mouse, no focus outline is added, but for keyboard Enter/Space, there is a focus outline).

Comment 3

[Sarah Clements [:sclements]]

(In reply to Anna Yeddi [:ayeddi] from comment #2)

(In reply to Sarah Clements [:sclements] from comment #1)

I'm not sure this is actually that much of an issue. Anna, what do you think about this?

I don't think we want to overwrite a default behavior of the page when the sidebar is opened. We do want to allow the sidebar to be focusable when it is open, but not by moving the focus there from a notification, especially when it's closed with a mouse event. With dialogs, for instance, we manage focus or not based on the source of the triggering event (if it's a mouse, no focus outline is added, but for keyboard Enter/Space, there is a focus outline).

Thanks Anna, I'll mark this as a P2/S3 but please let me know if we should bump this and fix it before the release experiment (vs before shipping to all users).