1921384 - Built-in console functions no longer work in the Service Worker console

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Dave]

Steps to reproduce:

1. In the latest Firefox Developer Edition (131.0b9) or Nightly, open a website with a Service Worker.

2. Navigate to about:debugging#/runtime/this-firefox and inspect the Service Worker.

3. In the Console tab, attempt to use console.log("hi").

Actual results:

It prints undefined and a blank line.

Expected results:

It should have printed undefined and a line with hi.

Comment 1

[Dave]

Note: This bug does not exist in the latest release version of Firefox (130.0.1) and it didn't exist in Firefox Developer Edition a couple of months ago (the last time I needed to look at logs in a Service Worker). Also, it seems to apply to more than just console.log. console.info, console.error, etc all fail to print and built-in functions like clear and dir return an Uncaught ReferenceError: clear is not defined.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

I can reproduce. I didn't double checked, but this is probably coming from Bug 1901644

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:ochameau, since you are the author of the regressor, bug 1901644, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1921384 - [devtools] Pass expected shape to onAvailableArray in legacy console messages listener. r=ochameau.

Add test case in about debugging for console API messages, and fix the
helper function that was asserting evaluation results, which was broken.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69fb148b68df
[devtools] Pass expected shape to onAvailableArray in legacy console messages listener. r=ochameau,devtools-reviewers.

Comment 6

[Noemi Erli[:noemi_erli]]

Backed out changeset 69fb148b68df (Bug 1921384) for causing devtools failures in browser_aboutdebugging_serviceworker_console.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=ThhJKUmuTCCBAWljCXq13A.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=69fb148b68df34a2dedd29d4b4ba51fa93cb49c1

Log: https://treeherder.mozilla.org/logviewer?job_id=476298073&repo=autoland&lineNumber=2954

Backout: https://hg.mozilla.org/integration/autoland/rev/9f9b1507c130b830d0471850aa40f81d8ac11195

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Looks like the test was a bit flaky when pausing in the debugger, I tried to fix this

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc70b1e542b4
[devtools] Pass expected shape to onAvailableArray in legacy console messages listener. r=ochameau,devtools-reviewers.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1901644

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/bc70b1e542b4

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:nchevobbe, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox132 to wontfix.

For more information, please visit BugBot documentation.

Comment 12

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1921384 - [devtools] Pass expected shape to onAvailableArray in legacy console messages listener. r=ochameau.

Add test case in about debugging for console API messages, and fix the
helper function that was asserting evaluation results, which was broken.

Original Revision: https://phabricator.services.mozilla.com/D224088

Comment 13

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Console API message (e.g. console.log) are not visible in the console
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: -
• Risk associated with taking this patch: low
• Explanation of risk level: one-liner devtools fix, covered by automated test
• String changes made/needed: -
• Is Android affected?: no

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/7ee0187e12a8