Closed Bug 1921617 Opened 1 year ago Closed 1 year ago

High frequency Linux shippable browser/components/customizableui/test/browser_876926_customize_mode_wrapping.js | Widget save-page-button was moved using drag and should now be wrapped in palette in customizing when Gecko 132 merges to beta on 2024-09-30

Categories

(Firefox :: Toolbars and Customization, defect)

defect

Tracking

()

RESOLVED FIXED
133 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- unaffected
firefox131 --- unaffected
firefox132 + fixed
firefox133 --- fixed

People

(Reporter: SerbanS, Assigned: aryx)

Details

Attachments

(1 file)

Central-as-beta-simulation

How to run these simulations

Failure log

[task 2024-09-28T11:31:55.799Z] 11:31:55     INFO - TEST-PASS | browser/components/customizableui/test/browser_876926_customize_mode_wrapping.js | Should end in default state - 
[task 2024-09-28T11:31:55.799Z] 11:31:55     INFO - Buffered messages finished
[task 2024-09-28T11:31:55.803Z] 11:31:55     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_876926_customize_mode_wrapping.js | Widget save-page-button was moved using drag and should now be wrapped in palette in customizing window. - Got "cui-mode-wrapping-some-panel-item", expected "save-page-button"
[task 2024-09-28T11:31:55.803Z] 11:31:55     INFO - Stack trace:
[task 2024-09-28T11:31:55.803Z] 11:31:55     INFO - chrome://mochikit/content/browser-test.js:test_is:1625
[task 2024-09-28T11:31:55.803Z] 11:31:55     INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/browser_876926_customize_mode_wrapping.js:checkPalette:218
[task 2024-09-28T11:31:55.803Z] 11:31:55     INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/browser_876926_customize_mode_wrapping.js:MoveWidgetsInTwoWindows:275
[task 2024-09-28T11:31:55.803Z] 11:31:55     INFO - chrome://mochikit/content/browser-test.js:handleTask:1145
[task 2024-09-28T11:31:55.803Z] 11:31:55     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1217
[task 2024-09-28T11:31:55.803Z] 11:31:55     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1358
[task 2024-09-28T11:31:55.803Z] 11:31:55     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1134
[task 2024-09-28T11:31:55.803Z] 11:31:55     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-09-28T11:31:55.803Z] 11:31:55     INFO - TEST-PASS | browser/components/customizableui/test/browser_876926_customize_mode_wrapping.js | There should be exactly 1 wrapper for save-page-button in the customizing window. - 

This started to be a high frequency failure on this central as beta simulation.

Hi Florian! Could this be associated with Bug 1918702?

Thank you!

Flags: needinfo?(florian)

(In reply to Serban Stanca [:SerbanS] from comment #1)

Hi Florian! Could this be associated with Bug 1918702?

It is not obviously related (I would expect failures related to changes from bug 1918702 to have identifiable error messages in the log; I see none in this case), but without knowing exactly what's happening I can't exclude it for sure.

Do you have a link to the pushlog of what landed between this beta simulation and the previous one?

Flags: needinfo?(florian) → needinfo?(sstanca)

(In reply to Florian Quèze [:florian] from comment #2)

(In reply to Serban Stanca [:SerbanS] from comment #1)

Hi Florian! Could this be associated with Bug 1918702?

It is not obviously related (I would expect failures related to changes from bug 1918702 to have identifiable error messages in the log; I see none in this case), but without knowing exactly what's happening I can't exclude it for sure.

Do you have a link to the pushlog of what landed between this beta simulation and the previous one?

@Florian, here's the requested pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c0d87b199f26&tochange=a38259f7bf5c

Flags: needinfo?(sstanca) → needinfo?(florian)

This test was disabled for linux !debug at bug 1682752 comment 74 and recently re-enabled at https://hg.mozilla.org/mozilla-central/rev/59fa1328930f79b47a3052363d9e89482915154e#l5.29 (bug 1917222).

Joel, should we just add back the skip-if? Maybe for some reason it fails at a high frequency only on beta but not on central?

Flags: needinfo?(florian) → needinfo?(jmaher)

it seems ok to skip this again, but as this seems to only be on a beta simulation, we could try skip-if = ["os == 'linux' && os_version == '18.04' && processor == 'x86_64' && beta_or_release"]

Flags: needinfo?(jmaher)

The failure has been observed frequently since the test got reenabled in
bug 1917222 but only for central-as-beta simulations.

Assignee: nobody → aryx.bugmail
Status: NEW → ASSIGNED
Pushed by sstanca@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ffcdbdb5214f disabled browser_876926_customize_mode_wrapping.js on Linux for Beta and Release. r=jmaher
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: