Closed Bug 1921706 Opened 1 month ago Closed 28 days ago

cleanup some libwebrtc BUILD.gn files to improve upcoming abseil-cpp move

Categories

(Core :: WebRTC, task)

task

Tracking

()

RESOLVED FIXED
133 Branch
Tracking Status
firefox133 --- fixed

People

(Reporter: mjf, Assigned: mjf)

References

Details

Attachments

(3 files)

There are a small set of changes we can make in a small number of BUILD.gn files that either:

  1. cleanup unnecessary changes
    or
  2. change dependency paths to relative paths (like others nearby)

In both cases, the BUILD.gn changes don't produce changes in the generated moz.build files, which is intended.

Blocks: 1921707

Note: this produces no changes in the generated moz.build files.

moz-central commit 85b5cef7ef21 (Bug 1654112 - Add check for mozilla build that was in the previous import, restore changes)
readded changes to third_party/libwebrtc/build/win/BUILD.gn that are not needed.

The include of webrtc.gni was originally added to reference our build_with_mozilla
flag, but then in same change we set build_with_mozilla back to false meaning we
never really needed the changes here at all.

Note: this produces no changes in the generated moz.build files.

o changeset: 597701:a26d44969a83
~ user: Michael Froman <mfroman@mozilla.com>
date: Mon Jun 14 17:39:29 2021 -0500
files: third_party/libwebrtc/build/config/linux/BUILD.gn
description:
Bug 1654112 - don't use libatomic on linux builds. r=ng

In moz-central a26d44969a83 I added an include of webrtc.gni for
the build_with_mozilla flag, but there is already a Mozilla
modifcation in this file that does not rely on that flag. This
simplification will help with future google build directory move.

Note: this produces no changes in the generated moz.build files.

Pushed by mfroman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e4b7dbca00cb remove unnecessary Mozilla mods to third_party/libwebrtc/build/win/BUILD.gn r=ng,webrtc-reviewers DONTBUILD https://hg.mozilla.org/integration/autoland/rev/d57bb9cfa9a7 simplify removing libatomic on linux builds. r=ng,webrtc-reviewers DONTBUILD https://hg.mozilla.org/integration/autoland/rev/bbec1b95ddb5 use relative paths on deps in a few places to avoid future issues. r=ng,webrtc-reviewers DONTBUILD
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: