1921707 - move abseil-cpp and the google build directory from libwebrtc to third_party

Status: RESOLVED FIXED

(Core :: WebRTC, task)

Description

[Michael Froman [:mjf]]

Moving the google build directory out of libwebrtc will allow us to support different google projects in our third_party directory. This is specifically to immediately move abseil-cpp from inside libwebrtc's third_party directory up to the Mozilla third_party directory. This should allow more frequent updates to abseil-cpp to support other libraries in moz-central.

Comment 1

[Michael Froman [:mjf]]

Attachment: Bug 1921707 - 'hg mv third_party/libwebrtc/third_party/abseil-cpp third_party/abseil-cpp' r?ng!

(skip-generation)

Comment 2

[Michael Froman [:mjf]]

Attachment: Bug 1921707 - 'hg mv third_party/libwebrtc/build third_party' r?ng!

Comment 3

[Michael Froman [:mjf]]

Attachment: Bug 1921707 - add trampoline third_party/abseil-cpp/third_party/abseil-cpp/absl.gni r?ng!

This avoids touching many (likely all) BUILD.gn files to point to the
top-level absl.gni file after the abseil-cpp location under Mozilla's
third_party directory.

Comment 4

[Michael Froman [:mjf]]

Attachment: Bug 1921707 - add trampoline third_party/libwebrtc/third_party/abseil-cpp/BUILD.gn r?ng!

Comment 5

[Michael Froman [:mjf]]

Attachment: Bug 1921707 - initial third_party/BUILD.gn to support building libwebrtc and abseil-cpp r?ng!

Comment 6

[Michael Froman [:mjf]]

Attachment: Bug 1921707 - libwebrtc preprocessor, .json, .gni, and *.gn changes r?ng!

Comment 7

[Michael Froman [:mjf]]

Attachment: Bug 1921707 - abseil-cpp preprocessor, .json, .gni, and *.gn changes r?ng!

Comment 8

[Michael Froman [:mjf]]

Attachment: Bug 1921707 - support new google build directory location in python/mozbuild/mozbuild/gn_processor.py r?ng!

Comment 9

[Michael Froman [:mjf]]

Attachment: Bug 1921707 - webrtc.gni - filter out '//third_party/abseil-cpp/' deps r?ng!

Comment 10

[Michael Froman [:mjf]]

Attachment: Bug 1921707 - absl.gni - filter dep paths from '//third_party/abseil-cpp/' to '//' r?ng!

Comment 11

[Michael Froman [:mjf]]

Attachment: Bug 1921707 - (MOZ) moz.build files point to new location for abseil-cpp r?ng!

Comment 12

[Michael Froman [:mjf]]

Attachment: Bug 1921707 - abseil-cpp - moz.build file updates r?ng!

Comment 13

[Michael Froman [:mjf]]

Attachment: Bug 1921707 - libwebrtc - moz.build file updates r?ng!

Comment 14

[Michael Froman [:mjf]]

Attachment: Bug 1921707 - 'hg mv third_party/libwebrtc/build third_party/chromium' r?glandium!

Comment 15

[Michael Froman [:mjf]]

Attachment: Bug 1921707 - point to new build directory location in third_party/chromium/build r?ng!

Ran:
ack -l ""//build/" third_party/chromium/build | xargs sed -i.bak -E 's/"//build//"//chromium/build//'
ack -l ""//build:" third_party/chromium/build | xargs sed -i.bak -E 's/"//build:/"//chromium/build:/'
find third_party -name "*.bak" | xargs rm
hg revert
third_party/chromium/build/android/pylib/utils/gold_utils.py
third_party/chromium/build/args/README.txt
third_party/chromium/build/args/chromeos/README.md
third_party/chromium/build/gn_helpers_unittest.py
third_party/chromium/build/locale_tool.py
third_party/chromium/build/toolchain/linux/unbundle/README.md

Comment 16

[Michael Froman [:mjf]]

Attachment: Bug 1921707 - point to new build directory location in third_party/libwebrtc r?ng!

Ran:
ack -l ""//build/config" third_party/libwebrtc | xargs sed -i.bak -E 's/"//build/config/"//chromium/build/config/'
ack -l ""//build/dot" third_party/libwebrtc | xargs sed -i.bak -E 's/"//build/dot/"//chromium/build/dot/'
ack -l ""//build/mac" third_party/libwebrtc | xargs sed -i.bak -E 's/"//build/mac/"//chromium/build/mac/'
find third_party -name "*.bak" | xargs rm
hg revert third_party/libwebrtc/moz-patch-stack

Comment 17

[Michael Froman [:mjf]]

Attachment: Bug 1921707 - point to new build directory location in third_party/abseil-cpp r?ng!

Ran:
ack -l ""//build/config" third_party/abseil-cpp | xargs sed -i.bak -E 's/"//build/config/"//chromium/build/config/'
ack -l ""//build/toolchain" third_party/abseil-cpp | xargs sed -i.bak -E 's/"//build/toolchain/"//chromium/build/toolchain/'
find third_party -name "*.bak" | xargs rm

Comment 18

[Michael Froman [:mjf]]

Attachment: Bug 1921707 - add filtering for new build directory location in third_party/libwebrtc/webrtc.gni r?ng!

Comment 19

[Michael Froman [:mjf]]

Attachment: Bug 1921707 - add filtering for new build directory location in third_party/abseil-cpp/absl.gni r?ng!

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d4bd04b6afa
'hg mv third_party/libwebrtc/third_party/abseil-cpp third_party/abseil-cpp' r=ng,webrtc-reviewers
https://hg.mozilla.org/integration/autoland/rev/f767612f7d35
add trampoline third_party/abseil-cpp/third_party/abseil-cpp/absl.gni r=ng
https://hg.mozilla.org/integration/autoland/rev/c345b27b2d81
add trampoline third_party/libwebrtc/third_party/abseil-cpp/BUILD.gn r=ng,webrtc-reviewers
https://hg.mozilla.org/integration/autoland/rev/b8d3694fe24f
initial third_party/BUILD.gn to support building libwebrtc and abseil-cpp r=ng
https://hg.mozilla.org/integration/autoland/rev/7017edc7cfc8
libwebrtc preprocessor, .json, .gni, and *.gn changes r=ng,webrtc-reviewers
https://hg.mozilla.org/integration/autoland/rev/6207cac8e337
abseil-cpp preprocessor, .json, .gni, and *.gn changes r=ng
https://hg.mozilla.org/integration/autoland/rev/62c95602f1e8
support new google build directory location in python/mozbuild/mozbuild/gn_processor.py r=ng
https://hg.mozilla.org/integration/autoland/rev/45b99d1ba95b
webrtc.gni - filter out '//third_party/abseil-cpp/' deps r=ng,webrtc-reviewers
https://hg.mozilla.org/integration/autoland/rev/afc78fbdb566
absl.gni - filter dep paths from '//third_party/abseil-cpp/' to '//' r=ng
https://hg.mozilla.org/integration/autoland/rev/c5a346c13dba
(MOZ) moz.build files point to new location for abseil-cpp r=ng
https://hg.mozilla.org/integration/autoland/rev/28e1734e3222
'hg mv third_party/libwebrtc/build third_party/chromium' r=glandium
https://hg.mozilla.org/integration/autoland/rev/6b855a2bf6b1
point to new build directory location in third_party/chromium/build r=ng,glandium
https://hg.mozilla.org/integration/autoland/rev/a342f5eca862
point to new build directory location in third_party/libwebrtc r=ng,webrtc-reviewers
https://hg.mozilla.org/integration/autoland/rev/566543823f7e
point to new build directory location in third_party/abseil-cpp r=ng
https://hg.mozilla.org/integration/autoland/rev/f18c05287ce8
add filtering for new build directory location in third_party/libwebrtc/webrtc.gni r=ng,webrtc-reviewers
https://hg.mozilla.org/integration/autoland/rev/c4cbc65577ab
add filtering for new build directory location in third_party/abseil-cpp/absl.gni r=ng
https://hg.mozilla.org/integration/autoland/rev/5ab34da720b8
abseil-cpp - moz.build file updates r=ng
https://hg.mozilla.org/integration/autoland/rev/7dc1ab196a73
libwebrtc - moz.build file updates r=ng,webrtc-reviewers

Comment 21

[Michael Froman [:mjf]]

Attachment: Bug 1921707 - lint fixes for Bugzilla components on new files/directories.

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7bdbc6499ff7
lint fixes for Bugzilla components on new files/directories.

Comment 23

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/0d4bd04b6afa
https://hg.mozilla.org/mozilla-central/rev/f767612f7d35
https://hg.mozilla.org/mozilla-central/rev/c345b27b2d81
https://hg.mozilla.org/mozilla-central/rev/b8d3694fe24f
https://hg.mozilla.org/mozilla-central/rev/7017edc7cfc8
https://hg.mozilla.org/mozilla-central/rev/6207cac8e337
https://hg.mozilla.org/mozilla-central/rev/62c95602f1e8
https://hg.mozilla.org/mozilla-central/rev/45b99d1ba95b
https://hg.mozilla.org/mozilla-central/rev/afc78fbdb566
https://hg.mozilla.org/mozilla-central/rev/c5a346c13dba
https://hg.mozilla.org/mozilla-central/rev/28e1734e3222
https://hg.mozilla.org/mozilla-central/rev/6b855a2bf6b1
https://hg.mozilla.org/mozilla-central/rev/a342f5eca862
https://hg.mozilla.org/mozilla-central/rev/566543823f7e
https://hg.mozilla.org/mozilla-central/rev/f18c05287ce8
https://hg.mozilla.org/mozilla-central/rev/c4cbc65577ab
https://hg.mozilla.org/mozilla-central/rev/5ab34da720b8
https://hg.mozilla.org/mozilla-central/rev/7dc1ab196a73
https://hg.mozilla.org/mozilla-central/rev/7bdbc6499ff7