1922264 - Container menu not shown when right-clicking new tab button when vertical tabs overflowing

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect)

Description

[Kestrel]

STR:

1. Start with sidebar.verticalTabs = true and sidebar.revamp = true.
2. Make sure privacy.userContext.enabled = true (default on Nightly).
3. Create many tabs so the list overflows (Ctrl+T).
4. Right-click on the new tab button in the sidebar.

Expected:
Container menu shown.

Actual:
Nothing happens.

Bug 1920575 fixed the non-overflowing case but broke the overflowing case.

Long-pressing still works regardless of overflow.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8ddc55eafb0d6c241bce583de1e3c1ad51f72b7b&tochange=350cbb95263323a35accdb31cc8b134d953ee93a

Regressed by Bug 1920575.

Comment 2

[Kestrel]

Bug 1920575 is the regressor so cannot be a duplicate unless it is reopened to fix this regression which it has not.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1920575

:nsharpley, since you are the author of the regressor, bug 1920575, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1922264 - Show container menu on right click of vertical tabs new tab button r=#sidebar-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59b51a655933
Show container menu on right click of vertical tabs new tab button r=sidebar-reviewers,Gijs

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/59b51a655933

Comment 7

[Dana Lucaci, Desktop QA]

Reproduced the issue with Firefox 133.0a1 (2024-10-02) on Windows 10.
The issue is verified fixed with Firefox 134.0a1 (20241105092845) and Firefox 133.0b4(20241104091514) on Windows 10, Ubuntu 22 and macOS 14.