1920575 - Vertical Tabs: Right click on new tab no longer shows container tab menu

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect)

Description

[Stuart Colville [:muffinresearch]]

A right click on the new tab button for Vertical tabs no longer shows the context menu for container tabs, breaking consistency with horizontal tabs.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1906888

Comment 2

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1920575 - Fix right click on new tab to show container tab menu r=#sidebar-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8aaffdf63d09
Fix right click on new tab to show container tab menu r=sidebar-reviewers,Gijs

Comment 4

[Iulian Moraru]

Backed out for causing bc failures on browser_sidebar_context_menu.js.

• Push with failures

• Failure log

• Backout link

[task 2024-09-27T18:17:18.373Z] 18:17:18     INFO - TEST-START | browser/components/sidebar/tests/browser/browser_sidebar_context_menu.js
[task 2024-09-27T18:17:18.617Z] 18:17:18     INFO - GECKO(25749) | 1727461038616	Marionette	TRACE	Received observer notification browser-delayed-startup-finished
[task 2024-09-27T18:18:03.381Z] 18:18:03     INFO - TEST-INFO | started process screentopng
[task 2024-09-27T18:18:03.515Z] 18:18:03     INFO - TEST-INFO | screentopng: exit 0
[task 2024-09-27T18:18:03.515Z] 18:18:03     INFO - Buffered messages logged at 18:17:18
[task 2024-09-27T18:18:03.516Z] 18:18:03     INFO - Entering test bound test_sidebar_extension_context_menu
[task 2024-09-27T18:18:03.518Z] 18:18:03     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_sidebar_context_menu.js | Sidebar is shown. - 
[task 2024-09-27T18:18:03.521Z] 18:18:03     INFO - Extension loaded
[task 2024-09-27T18:18:03.521Z] 18:18:03     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_sidebar_context_menu.js | Extension is shown in the sidebar. - 
[task 2024-09-27T18:18:03.521Z] 18:18:03     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_sidebar_context_menu.js | Checking if context menu is closed - 
[task 2024-09-27T18:18:03.521Z] 18:18:03     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_sidebar_context_menu.js | Context menu hidden when anything other than button is right clicked - 
[task 2024-09-27T18:18:03.521Z] 18:18:03     INFO - wait for the context menu to open
[task 2024-09-27T18:18:03.521Z] 18:18:03     INFO - Buffered messages finished
[task 2024-09-27T18:18:03.521Z] 18:18:03     INFO - TEST-UNEXPECTED-FAIL | browser/components/sidebar/tests/browser/browser_sidebar_context_menu.js | Test timed out - 
[task 2024-09-27T18:18:03.522Z] 18:18:03     INFO - GECKO(25749) | Completed ShutdownLeaks collections in process 25749
[task 2024-09-27T18:18:03.522Z] 18:18:03     INFO - TEST-START | Shutdown
[task 2024-09-27T18:18:03.522Z] 18:18:03     INFO - Browser Chrome Test Summary
[task 2024-09-27T18:18:03.522Z] 18:18:03     INFO - Passed:  172
[task 2024-09-27T18:18:03.522Z] 18:18:03     INFO - Failed:  1
[task 2024-09-27T18:18:03.522Z] 18:18:03     INFO - Todo:    0
[task 2024-09-27T18:18:03.522Z] 18:18:03     INFO - Mode:    e10s
[task 2024-09-27T18:18:03.522Z] 18:18:03     INFO - *** End BrowserChrome Test Results ***
[task 2024-09-27T18:18:03.522Z] 18:18:03     INFO - GECKO(25749) | Exiting due to channel error.
[task 2024-09-27T18:18:03.522Z] 18:18:03     INFO - GECKO(25749) | Exiting due to channel error.
[task 2024-09-27T18:18:03.523Z] 18:18:03     INFO - GECKO(25749) | Exiting due to channel error.
[task 2024-09-27T18:18:03.523Z] 18:18:03     INFO - GECKO(25749) | Exiting due to channel error.
[task 2024-09-27T18:18:03.523Z] 18:18:03     INFO - GECKO(25749) | Exiting due to channel error.
[task 2024-09-27T18:18:03.523Z] 18:18:03     INFO - GECKO(25749) | Exiting due to channel error.
[task 2024-09-27T18:18:03.523Z] 18:18:03     INFO - GECKO(25749) | Exiting due to channel error.
[task 2024-09-27T18:18:03.524Z] 18:18:03     INFO - GECKO(25749) | Exiting due to channel error.
[task 2024-09-27T18:18:03.525Z] 18:18:03     INFO - TEST-INFO | Main app process: exit 0
[task 2024-09-27T18:18:03.525Z] 18:18:03     INFO - runtests.py | Application ran for: 0:01:09.223019

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/649e6cb6fde3
Backed out changeset 8aaffdf63d09 for causing bc failures on browser_sidebar_context_menu.js. CLOSED TREE

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1906888

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/350cbb952633
Fix right click on new tab to show container tab menu r=sidebar-reviewers,Gijs,sfoster

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/350cbb952633

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Did you want to nominate this for Beta uplift?

Comment 11

[Dana Lucaci, Desktop QA]

Reproduced the issue with Firefox 132.0a1 (2024-09-23) on Windows 10.
The issue is verified fixed with Firefox 134.0a1 (20241105092845) and Firefox 133.0b4(20241104091514) on Windows 10, Ubuntu 22 and macOS 14.