Open Bug 1920575 Opened 5 days ago Updated 18 hours ago

Vertical Tabs: Right click on new tab no longer shows container tab menu

Categories

(Firefox :: Sidebar, defect)

defect

Tracking

()

ASSIGNED
Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- unaffected
firefox130 --- unaffected
firefox131 --- unaffected
firefox132 --- affected

People

(Reporter: muffinresearch, Assigned: nsharpley, NeedInfo)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [fidefe-sidebar])

Attachments

(1 file)

A right click on the new tab button for Vertical tabs no longer shows the context menu for container tabs, breaking consistency with horizontal tabs.

Whiteboard: [fidefe-sidebar]
Assignee: nobody → sclements
Status: NEW → ASSIGNED
Assignee: sclements → nsharpley
Attachment #9427479 - Attachment description: WIP: Bug 1920575 - Fix right click on new tab to show container tab menu → Bug 1920575 - Fix right click on new tab to show container tab menu r=#sidebar-reviewers
Pushed by nsharpley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8aaffdf63d09 Fix right click on new tab to show container tab menu r=sidebar-reviewers,Gijs

Backed out for causing bc failures on browser_sidebar_context_menu.js.

[task 2024-09-27T18:17:18.373Z] 18:17:18     INFO - TEST-START | browser/components/sidebar/tests/browser/browser_sidebar_context_menu.js
[task 2024-09-27T18:17:18.617Z] 18:17:18     INFO - GECKO(25749) | 1727461038616	Marionette	TRACE	Received observer notification browser-delayed-startup-finished
[task 2024-09-27T18:18:03.381Z] 18:18:03     INFO - TEST-INFO | started process screentopng
[task 2024-09-27T18:18:03.515Z] 18:18:03     INFO - TEST-INFO | screentopng: exit 0
[task 2024-09-27T18:18:03.515Z] 18:18:03     INFO - Buffered messages logged at 18:17:18
[task 2024-09-27T18:18:03.516Z] 18:18:03     INFO - Entering test bound test_sidebar_extension_context_menu
[task 2024-09-27T18:18:03.518Z] 18:18:03     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_sidebar_context_menu.js | Sidebar is shown. - 
[task 2024-09-27T18:18:03.521Z] 18:18:03     INFO - Extension loaded
[task 2024-09-27T18:18:03.521Z] 18:18:03     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_sidebar_context_menu.js | Extension is shown in the sidebar. - 
[task 2024-09-27T18:18:03.521Z] 18:18:03     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_sidebar_context_menu.js | Checking if context menu is closed - 
[task 2024-09-27T18:18:03.521Z] 18:18:03     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_sidebar_context_menu.js | Context menu hidden when anything other than button is right clicked - 
[task 2024-09-27T18:18:03.521Z] 18:18:03     INFO - wait for the context menu to open
[task 2024-09-27T18:18:03.521Z] 18:18:03     INFO - Buffered messages finished
[task 2024-09-27T18:18:03.521Z] 18:18:03     INFO - TEST-UNEXPECTED-FAIL | browser/components/sidebar/tests/browser/browser_sidebar_context_menu.js | Test timed out - 
[task 2024-09-27T18:18:03.522Z] 18:18:03     INFO - GECKO(25749) | Completed ShutdownLeaks collections in process 25749
[task 2024-09-27T18:18:03.522Z] 18:18:03     INFO - TEST-START | Shutdown
[task 2024-09-27T18:18:03.522Z] 18:18:03     INFO - Browser Chrome Test Summary
[task 2024-09-27T18:18:03.522Z] 18:18:03     INFO - Passed:  172
[task 2024-09-27T18:18:03.522Z] 18:18:03     INFO - Failed:  1
[task 2024-09-27T18:18:03.522Z] 18:18:03     INFO - Todo:    0
[task 2024-09-27T18:18:03.522Z] 18:18:03     INFO - Mode:    e10s
[task 2024-09-27T18:18:03.522Z] 18:18:03     INFO - *** End BrowserChrome Test Results ***
[task 2024-09-27T18:18:03.522Z] 18:18:03     INFO - GECKO(25749) | Exiting due to channel error.
[task 2024-09-27T18:18:03.522Z] 18:18:03     INFO - GECKO(25749) | Exiting due to channel error.
[task 2024-09-27T18:18:03.523Z] 18:18:03     INFO - GECKO(25749) | Exiting due to channel error.
[task 2024-09-27T18:18:03.523Z] 18:18:03     INFO - GECKO(25749) | Exiting due to channel error.
[task 2024-09-27T18:18:03.523Z] 18:18:03     INFO - GECKO(25749) | Exiting due to channel error.
[task 2024-09-27T18:18:03.523Z] 18:18:03     INFO - GECKO(25749) | Exiting due to channel error.
[task 2024-09-27T18:18:03.523Z] 18:18:03     INFO - GECKO(25749) | Exiting due to channel error.
[task 2024-09-27T18:18:03.524Z] 18:18:03     INFO - GECKO(25749) | Exiting due to channel error.
[task 2024-09-27T18:18:03.525Z] 18:18:03     INFO - TEST-INFO | Main app process: exit 0
[task 2024-09-27T18:18:03.525Z] 18:18:03     INFO - runtests.py | Application ran for: 0:01:09.223019
Flags: needinfo?(nsharpley)
Backout by imoraru@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/649e6cb6fde3 Backed out changeset 8aaffdf63d09 for causing bc failures on browser_sidebar_context_menu.js. CLOSED TREE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: