Use asyncOpenTime instead of channelCreationTime for BiDi network event timings
Categories
(Remote Protocol :: WebDriver BiDi, defect, P3)
Tracking
(firefox132 fixed, firefox133 fixed)
People
(Reporter: jdescottes, Assigned: jdescottes)
References
(Blocks 3 open bugs)
Details
(Whiteboard: [webdriver:m13][wptsync upstream][webdriver:relnote])
Attachments
(2 files)
Bug 1922390 - [bidi] Use asyncOpenTime instead of channelCreationTime for bidi network event timings
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
We currently use channelCreationTime
as the request start time for our BiDi network events.
However, the value might be wrong, eg if we happen to recycle an existing channel. It would be more accurate to rely on asyncOpenTime
.
We should also update the current tests to account for potential rounding issues.
Assignee | ||
Comment 1•2 months ago
|
||
Updated•2 months ago
|
Assignee | ||
Comment 2•2 months ago
|
||
Depends on D224442
Timings from the bidi network events have higher precision than what current_time returns,
allow for an extra second in the time range to avoid intermittent failures for rounding issues.
Assignee | ||
Updated•2 months ago
|
Comment 5•2 months ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b22bebcfaa9a
https://hg.mozilla.org/mozilla-central/rev/a82529715a00
Assignee | ||
Comment 7•2 months ago
|
||
Comment on attachment 9428747 [details]
Bug 1922390 - [bidi] Use asyncOpenTime instead of channelCreationTime for bidi network event timings
Beta/Release Uplift Approval Request
- User impact if declined/Reason for urgency: Fixes frequent intermittent failures in beta windows wdspec jobs eg https://bugzilla.mozilla.org/show_bug.cgi?id=1875706 and https://bugzilla.mozilla.org/show_bug.cgi?id=1920369
Note that the fix is not eliminating all failures, but it makes it much less frequent
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Mostly a test change + reading another field from a webidl to compute WebDriver BiDi event timings
- String changes made/needed:
- Is Android affected?: No
Comment 8•2 months ago
|
||
Comment on attachment 9428747 [details]
Bug 1922390 - [bidi] Use asyncOpenTime instead of channelCreationTime for bidi network event timings
Approved for 132.0b8.
Updated•2 months ago
|
Updated•2 months ago
|
Updated•2 months ago
|
Description
•