1922390 - Use asyncOpenTime instead of channelCreationTime for BiDi network event timings

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P3)

Description

[Julian Descottes [:jdescottes]]

We currently use channelCreationTime as the request start time for our BiDi network events.
However, the value might be wrong, eg if we happen to recycle an existing channel. It would be more accurate to rely on asyncOpenTime.

We should also update the current tests to account for potential rounding issues.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1922390 - [bidi] Use asyncOpenTime instead of channelCreationTime for bidi network event timings

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1922390 - [wdspec] Avoid rounding issues with request timing assertions

Depends on D224442
Timings from the bidi network events have higher precision than what current_time returns,
allow for an extra second in the time range to avoid intermittent failures for rounding issues.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b22bebcfaa9a
[bidi] Use asyncOpenTime instead of channelCreationTime for bidi network event timings r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/a82529715a00
[wdspec] Avoid rounding issues with request timing assertions r=webdriver-reviewers,Sasha

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/48519 for changes under testing/web-platform/tests

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b22bebcfaa9a
https://hg.mozilla.org/mozilla-central/rev/a82529715a00

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 7

[Julian Descottes [:jdescottes]]

Comment on attachment 9428747 [details]
Bug 1922390 - [bidi] Use asyncOpenTime instead of channelCreationTime for bidi network event timings

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Fixes frequent intermittent failures in beta windows wdspec jobs eg https://bugzilla.mozilla.org/show_bug.cgi?id=1875706 and https://bugzilla.mozilla.org/show_bug.cgi?id=1920369

Note that the fix is not eliminating all failures, but it makes it much less frequent

• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Mostly a test change + reading another field from a webidl to compute WebDriver BiDi event timings
• String changes made/needed:
• Is Android affected?: No

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9428747 [details]
Bug 1922390 - [bidi] Use asyncOpenTime instead of channelCreationTime for bidi network event timings

Approved for 132.0b8.

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/7c99381b6be0
https://hg.mozilla.org/releases/mozilla-beta/rev/fdb9fd3bc41d