Closed Bug 1922390 Opened 2 months ago Closed 2 months ago

Use asyncOpenTime instead of channelCreationTime for BiDi network event timings

Categories

(Remote Protocol :: WebDriver BiDi, defect, P3)

defect
Points:
2

Tracking

(firefox132 fixed, firefox133 fixed)

RESOLVED FIXED
133 Branch
Tracking Status
firefox132 --- fixed
firefox133 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 3 open bugs)

Details

(Whiteboard: [webdriver:m13][wptsync upstream][webdriver:relnote])

Attachments

(2 files)

We currently use channelCreationTime as the request start time for our BiDi network events.
However, the value might be wrong, eg if we happen to recycle an existing channel. It would be more accurate to rely on asyncOpenTime.

We should also update the current tests to account for potential rounding issues.

Assignee: nobody → jdescottes
Status: NEW → ASSIGNED

Depends on D224442
Timings from the bidi network events have higher precision than what current_time returns,
allow for an extra second in the time range to avoid intermittent failures for rounding issues.

Blocks: 1875706
Blocks: 1921712
Severity: -- → S3
Points: --- → 2
Priority: -- → P3
Whiteboard: [webdriver:m13]
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b22bebcfaa9a [bidi] Use asyncOpenTime instead of channelCreationTime for bidi network event timings r=webdriver-reviewers,Sasha https://hg.mozilla.org/integration/autoland/rev/a82529715a00 [wdspec] Avoid rounding issues with request timing assertions r=webdriver-reviewers,Sasha
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/48519 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m13] → [webdriver:m13], [wptsync upstream]
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
Upstream PR merged by moz-wptsync-bot

Comment on attachment 9428747 [details]
Bug 1922390 - [bidi] Use asyncOpenTime instead of channelCreationTime for bidi network event timings

Beta/Release Uplift Approval Request

Note that the fix is not eliminating all failures, but it makes it much less frequent

  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Mostly a test change + reading another field from a webidl to compute WebDriver BiDi event timings
  • String changes made/needed:
  • Is Android affected?: No
Attachment #9428747 - Flags: approval-mozilla-beta?

Comment on attachment 9428747 [details]
Bug 1922390 - [bidi] Use asyncOpenTime instead of channelCreationTime for bidi network event timings

Approved for 132.0b8.

Attachment #9428747 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9428748 - Flags: approval-mozilla-beta+
Whiteboard: [webdriver:m13], [wptsync upstream] → [webdriver:m13][wptsync upstream][webdriver:relnote]
Regressions: 1930849
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: