Closed Bug 1930849 Opened 9 months ago Closed 9 months ago

Network event requestTime is sometimes set to 0

Categories

(Remote Protocol :: WebDriver BiDi, defect, P2)

Firefox 132
defect
Points:
2

Tracking

(firefox-esr115 unaffected, firefox-esr128 unaffected, firefox132 wontfix, firefox133 wontfix, firefox134 fixed)

RESOLVED FIXED
134 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- unaffected
firefox132 --- wontfix
firefox133 --- wontfix
firefox134 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [webdriver:m13][webdriver:relnote])

Attachments

(1 file)

Since switching to asyncOpenTime instead of channelCreationTime, we sometimes get network events with a requestTime of 0, which means asyncOpenTime was set to 0.

This seems to happen intermittently on the following website, but probably happens in other situations: https://www.hs.fi/

It seems the issue triggers more consistently with the following STRs:

  • open new tab
  • load data:text/html;charset=utf-8,<html><body></body></html> in the new tab
  • navigate to https://www.hs.fi/

The URLs for which this happens seem to change from reload to reload, I've seen it occur on the following URLs so far:

Using devtools netmonitor in parallel to inspect the problematic requests, it seems that there is usually caching involved, but no service workers (there doesn't seem to be any on the page anyway).

Valentin, any idea in which situation we might have 0 as asyncOpenTime? I'm guessing we can fallback to channelCreationTime in that case, but maybe this is a bug which should also be investigated on necko's side?

Flags: needinfo?(valentin.gosu)

The root cause for asyncOpenTime = 0 should be investigated, but this leads to missing events in har recordings so we should try to fix it as soon as possible.

Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Points: --- → 2
Priority: -- → P2
Whiteboard: [webdriver:m13]
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/740badf2c13f [bidi] Fallback to channelCreationTime if asyncOpenTime is set to 0 r=webdriver-reviewers,whimboo
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch
Flags: needinfo?(valentin.gosu)

(In reply to Julian Descottes [:jdescottes] from comment #1)

Valentin, any idea in which situation we might have 0 as asyncOpenTime? I'm guessing we can fallback to channelCreationTime in that case, but maybe this is a bug which should also be investigated on necko's side?

This needinfo is still valid and we would like to hear from Valentin. What we landed is just a workaround.

Flags: needinfo?(valentin.gosu)

Julian, I did a try push with this line commented:
https://treeherder.mozilla.org/jobs?repo=try&revision=0e479c1ed57b194274bdf537190e2594e9129b8b
Could you check if fixes the problem?

Flags: needinfo?(valentin.gosu) → needinfo?(jdescottes)

(In reply to Valentin Gosu [:valentin] (he/him) from comment #6)

Julian, I did a try push with this line commented:
https://treeherder.mozilla.org/jobs?repo=try&revision=0e479c1ed57b194274bdf537190e2594e9129b8b
Could you check if fixes the problem?

Thanks! Looks like this fixes the issue, I no longer see asyncOpenTime=0 on https://www.hs.fi/
Do you want me to file another bug to handle the fix?

Flags: needinfo?(jdescottes) → needinfo?(valentin.gosu)
See Also: → 1931514

(In reply to Julian Descottes [:jdescottes] from comment #7)

Do you want me to file another bug to handle the fix?

I filed bug 1931514 for this.

Flags: needinfo?(valentin.gosu)

The patch landed in nightly and beta is affected.
:jdescottes, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox133 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(jdescottes)
Blocks: 1931528
Flags: needinfo?(jdescottes)
Whiteboard: [webdriver:m13] → [webdriver:m13][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: