1922398 - New Tab: Settings button is the first in the focus order when it is visually placed after the Weather widget

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P3)

Description

[Anna Yeddi [:ayeddi]]

Attachment: Accessibility Inspector of Firefox showing Tabbing order for the New Tab page where the Settings button is the first in the order is placed in the right corner

STR:

1. Open Firefox on the New Tab page
2. Press Tab key to focus the Settings button and observe the focus order

Expected:

1. The Settings (gear icon) button is receiving focus after the Weather widget, because it is placed visually at the end of the first row of controls, on the right side from the Weather widget (on English build)

Actual:

1. The Settings (gear icon) button is the first element in the focus order on the New Tab page making it hard to expect and follow for sighted keyboard users, because it is expected the focus order would follow the visual reading order of the page and would go from left to right, top to bottom (for LTR languages)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:thecount, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Maxx Crawford [:maxx]]

Triage reasoning:

• Severity: -- → S3: Work around exists for this issue
• Priority: -- → P3: Backlog

Comment 3

[Irene Ni [:ini]]

Attachment: Bug 1922398 - Fix New Tab Customize button focus order. r=#home-newtab-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8907898a3a55
https://hg.mozilla.org/integration/autoland/rev/323483920c73
Fix New Tab Customize button focus order. r=home-newtab-reviewers,nbarrett,ayeddi

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/323483920c73