1922898 - tabbar background becomes a default opaque color when losing focus

Status: NEW

(Firefox :: Theme, defect, P1)

Description

[lilydjwg]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:133.0) Gecko/20100101 Firefox/133.0

Steps to reproduce:

• Install a theme with a background image, e.g. my one https://addons.mozilla.org/firefox/addon/transgender-pride-2/
• enable window title in the customization
• switch to another window but make the firefox window still visible

Actual results:

The tabbar background becomes a default opaque color (a nearly white color for me). The theme's background is gone.

Expected results:

The tabbar should still have the background image.

regressed by bug 1899598.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Theme' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[lilydjwg]

No, mozregression doesn't point to bug 1922802:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b17f4d3142eeb0488513b984c8f5113e80101b96&tochange=82dacb5e3821fc0081deed13bd932839d65867e0

It contains only bug 1899598.

Comment 3

[Donal Meehan [:dmeehan]]

(In reply to lilydjwg from comment #2)

No, mozregression doesn't point to bug 1922802:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b17f4d3142eeb0488513b984c8f5113e80101b96&tochange=82dacb5e3821fc0081deed13bd932839d65867e0

It contains only bug 1899598.

Thanks, copy-paste error

Comment 4

[Dão Gottwald [:dao]]

[Tracking Requested - why for this release]:

Related to this, with the title bar disabled, I get the theme's background on the nav bar but it's mixed with the title bar background which looks a bit odd. The menu toolbar, if enabled (not available on macOS, mind you), does not get the title bar background so the nav bar looks even more odd. Sam, probably makes sense to handle all these cases in this bug?

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug has a release status flag that shows some version of Firefox is affected, thus it will be considered confirmed.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox133 (nightly). However, the bug still isn't assigned.

:cbellini, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 7

[Sam Foster [:sfoster] (he/him)]

I can take this one. Its fallout from bug 1899598 .

Comment 8

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1922898 - Correct inactive titlebar color in linux; ensure titlebar toolbars get the browser-titlebar class. r?#desktop-theme-reviewers!