1922802 - Vertical tabs: address bar dropdown is transparent, bookmark toolbar can be clicked through it

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Nils]

Attachment: 2024-10-04 16_21_11-.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:133.0) Gecko/20100101 Firefox/133.0

Steps to reproduce:

Updated to latest nightly from the website.

Actual results:

Please refer to this (closed) bug as well: https://bugzilla.mozilla.org/show_bug.cgi?id=1922546#c12

This has been marked as fixed, but as far as I can see the z-index of the bookmarks toolbar is now the same as the z-index of the dropdown menu. This is with vertical tabs enabled.

Expected results:

z-index of the dropdown should be greater than the z-index for the bookmarks toolbar.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Mark]

I ran a mozregression for Bug 1922827 and the bottom of the regression showed:

Bug 1899598 - Hide the horizontal tab strip when vertical tabs are enabled. r=mconley,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,emilio,willdurand,sclements

• Remove the #titlebar element, and ensure toolbars that comprise the titlebar get a .browser-titlebar class
• Ensure we call TabBarVisibility.update when initializing with verticalTab=true
• Adjust TabBarVisibility logic so we allow for the vertical tabs case
• Give #navigator-toolbar z-index: var(--browser-area-z-index-toolbox) to ensure the urlbar view doesnt get clipped behind the lower elements

Differential Revision: https://phabricator.services.mozilla.com/D222059

2024-10-04T11:17:35.201000: DEBUG : Did not find a branch, checking all integration branches
2024-10-04T11:17:35.206000: INFO : The bisection is done.
2024-10-04T11:17:35.209000: INFO : Stopped

Comment 4

[Francesco Lodolo [:flod]]

[Tracking Requested - why for this release]: address bar not functional with optional vertical tabs enabled.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox133 (nightly). However, the bug still isn't assigned.

:cbellini, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 8

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1922802 - Set z-index on nav bar to prevent PersonalToolbar overlapping address dropdown r=#sidebar-reviewers

Comment 9

[Sam Foster [:sfoster] (he/him)]

:nikkis is looking at this one.

Comment 13

[Erwan]

This bug just appeared with the latest update. I had nothing at all before.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba57d03292b6
Set z-index on nav bar to prevent PersonalToolbar overlapping address dropdown r=sidebar-reviewers,desktop-theme-reviewers,sfoster

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ba57d03292b6

Comment 16

[Erwan]

Updated today, so far everything is working fine. (Nightly Version 133.0a1 build ID 20241009214609).

Comment 17

[Serban Stanca [:SerbanS]]

Backed out as requested for causing Bug 1923836.

• Backout link

Comment 18

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/c1e76f8db405
Backed out changeset ba57d03292b6 as requested for causing Bug 1923836.

Comment 22

[Stuart Colville [:muffinresearch]]

This looks to have been fixed by the fix for bug 1921811 testing on windows 11 and mac with nightly 2024-10-22

Comment 25

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

I was able to reproduce the issue on an affected Firefox Nightly build from 2024-10-09, using Windows 11, as shown in Comment 0.
Verified as fixed on Firefox 133.0b8 using Windows 11, macOS 14.7 and Ubuntu 22.04. The address bar dropdown is no longer transparent.