1922961 - Windows Settings: "Notification & actions" (Manage notifications) don't show TB icon

Status: RESOLVED FIXED

(Thunderbird :: OS Integration, defect)

Description

[betterbird.project+18]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/129.0.0.0 Safari/537.36 Edg/129.0.0.0

Steps to reproduce:

The issue is that "VisualElements" for TB isn't located in a folder "browser":
https://searchfox.org/comm-central/rev/6ccfe95ce68db5713fb58b5139a97e2bf7ca4eb6/mail/installer/windows/nsis/shared.nsh#1662
https://searchfox.org/mozilla-central/rev/906cf04e249dd79ee496f01f9ed79cc16b1ff78c/widget/windows/ToastNotification.cpp#183
Fixes:
https://github.com/Betterbird/thunderbird-patches/blob/main/128/bugs/NNN19-fix-icon-URL-toast-icon.patch
https://github.com/Betterbird/thunderbird-patches/blob/3a4c941c03d3b6e705d0a248e812b947b076b642/128/bugs/NNN19-fix-icon-URL-toast-icon-moz.patch#L15

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug 1922961 - Fix the path to the toast icon in installer. r=rjl

Comment 3

[betterbird.project+18]

How do you intend to fix
https://searchfox.org/mozilla-central/rev/7db217e3832e9a884be0c2300779e098f92be3fe/widget/windows/ToastNotification.cpp#183
?

Comment 4

[Richard Marti (:Paenglab)]

When I have time. Over this weekend.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/99c72151ec3c
Fix the path to the toast icon in installer. r=rjl

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 9429229 [details]
Bug 1922961 - Fix the path to the toast icon in installer. r=rjl

[Approval Request Comment]
Regression caused by (bug #): bug 1838139
User impact if declined: toast notification shows no TB icon
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 7

[Corey Bryant]

Comment on attachment 9429229 [details]
Bug 1922961 - Fix the path to the toast icon in installer. r=rjl

[Triage Comment]
Approved for beta

Comment 8

[Corey Bryant]

Thunderbird 132.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/63fe2e0b1f64

Comment 9

[Richard Marti (:Paenglab)]

Attachment: Bug 1922961 - Don't append the browser subdirectory in Thunderbird. r=#win-reviewers

Comment 10

[Corey Bryant]

Comment on attachment 9429229 [details]
Bug 1922961 - Fix the path to the toast icon in installer. r=rjl

[Triage Comment]
Richard, are both patches needed in order to fix this?

Comment 11

[Corey Bryant]

Rob is going to revert this in Thunderbird 132.0b5. And we'll hold off until the m-c fix is in mozilla-beta.

Comment 12

[betterbird.project+18]

There is no need. The parts are independent, the Mozilla change is for a different registry entry added at runtime. For as much as we can tell, the C-C part already fixes the missing icon. Does it not?

Comment 13

[Richard Marti (:Paenglab)]

(In reply to Corey Bryant from comment #10)

[Triage Comment]
Richard, are both patches needed in order to fix this?

The C-C patch can still land as there is an error in path in installer that prohibits to get the correct icon.

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9429229 [details]
Bug 1922961 - Fix the path to the toast icon in installer. r=rjl

[Triage Comment]
(re)Approved for beta (already landed)

Comment 15

[Corey Bryant]

Comment on attachment 9429229 [details]
Bug 1922961 - Fix the path to the toast icon in installer. r=rjl

[Triage Comment]
Approved for esr128

Comment 16

[Rob Lemley [:rjl]]

Thunderbird 128.3.3esr:
https://hg.mozilla.org/releases/comm-esr128/rev/21cd838dcdfc

Comment 17

[Richard Marti (:Paenglab)]

Reopened for M-C part.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc6ed6497320
Don't append the browser subdirectory in Thunderbird. r=win-reviewers,handyman

Comment 19

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/cc6ed6497320

Comment 20

[Richard Marti (:Paenglab)]

Comment on attachment 9430554 [details]
Bug 1922961 - Don't append the browser subdirectory in Thunderbird. r=#win-reviewers

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Thunderbirds releases are based on ESR.
• User impact if declined: On Thunderbird the toast notifications are missing the icon because the path goes to browser/ which is for Firefox only.
• Fix Landed on Version: 133
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple preprocessor rule to include the code for Firefox only.

Comment 21

[Donal Meehan [:dmeehan]]

Comment on attachment 9430554 [details]
Bug 1922961 - Don't append the browser subdirectory in Thunderbird. r=#win-reviewers

Approved for 128.5esr.

Comment 22

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/5a74da019021

Comment 23

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello,

Are there any specific STR that QA could perform in order to reproduce the faulty behaviour(crash) on an affected build and properly verify and confirm that it is fixed?