1923039 - Don't treat lint warnings as errors locally

Status: NEW

(Firefox for Android :: Tooling, task, P2)

Description

[Polly [:polly]]

Currently android compiler warnings are treated as errors during local builds.
This is annoying if you are mid-development and want to try something out in the app while the code is in a non-perfect state.
We would like to speed up the build feedback loop by not failing the build for warnings when building locally.
We do want to retain the behaviour where lint warnings don't pass CI builds.
The ideal process would be something like:

• play around freely with code locally, and the code builds fine with warnings
• run mach lint or similar before pushing changes. This would fail for lint warnings so you fix stuff before checking in.
• push changes - if you haven't fixed lint warnings by this stage they would fail the build.

Comment 1

[Polly [:polly]]

Here are the places we are currently setting warningsAsErrors fyi: https://searchfox.org/mozilla-central/search?q=warningsaserrors&path=build.gradle&case=false&regexp=false
If we get rid of this flag, we will be able to work freely and build code locally with compile warnings, but the linters will still run on CI

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Does this mean that compiler warnings won't be fatal anymore? Because that seems independent of how we treat linter warnings.

Comment 3

[Polly [:polly]]

yes i am talking about making compiler warnings non-fatal but still requiring linters to pass. i'll edit for clarity :)