1923052 - "Private browsing" icon/label no longer shown in titlebar with vertical tabs

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect, P1)

Description

[Kestrel]

Attachment: Missing "Private browsing" mask icon and label in titlebar with vertical tabs

STR:

1. Start with sidebar.verticalTabs = true and sidebar.revamp = true.
2. Enable Light/Dark theme that does not style private windows differently.
3. Create a private window.

Expected:
Some indication of private browsing in the titlebar.

Actual:
The "Private browsing" icon and label is missing.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b17f4d3142eeb0488513b984c8f5113e80101b96&tochange=82dacb5e3821fc0081deed13bd932839d65867e0

Regressed by Bug 1899598.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:sfoster, since you are the author of the regressor, bug 1899598, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Sam Foster [:sfoster] (he/him)]

I think the private browsing label probably needs to get grouped with the window controls and post-tabs spacer in this case.

Comment 3

[Stuart Colville [:muffinresearch]]

Noting that the solution for this should be discussed with UX on how this looks when we get to it, plus Yulia is looking into badging options as well.

Comment 4

[Ania]

Hi Nicole,
We were hoping to check in with you on whether displaying the text label "Private mode" is necessary for the vertical tabs mode orientation or whether displaying only the toolbar icon (and thus saving space in the toolbar) could be an acceptable indicator of the private mode?

Comment 5

[[e-mail]]

Ania just filled me in over slack. I think it makes the most sense to just show the icon as that will read cleaner in vertical tabs. The label makes it hard to tell what is going on when it would be better to just have the tab title there for easy scanning.

Comment 6

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1923052 - Show private browsing indicator icon in navbar when vertical tabs are enabled

Comment 7

[Nicole Weber [:topotropic]]

(In reply to Ania from comment #4)

Hi Nicole,
We were hoping to check in with you on whether displaying the text label "Private mode" is necessary for the vertical tabs mode orientation or whether displaying only the toolbar icon (and thus saving space in the toolbar) could be an acceptable indicator of the private mode?

Thanks for the ping, Ania!

Where in the toolbar would the icon live? Something to consider is that everything right of the toolbar is clickable today and depending on placement the privacy icon could look like an extension or some other functional element.

Did we explore other options like adding it at the top of the vertical tabs? This could be even more helpful and reassuring to have the private tabs and the icon close to each other

Comment 8

[Sarah Clements [:sclements]]

Attachment: Screenshot 2024-10-22 at 10.54.39.png

Comment 9

[Sarah Clements [:sclements]]

(In reply to Nicole Weber [:topotropic] from comment #7)

(In reply to Ania from comment #4)
Where in the toolbar would the icon live? Something to consider is that everything right of the toolbar is clickable today and depending on placement the privacy icon could look like an extension or some other functional element.

Hi Nicole, I posted a screenshot from Kelly's patch - as you can see it keeps the private browsing icon in the same location but removes the text.

Did we explore other options like adding it at the top of the vertical tabs? This could be even more helpful and reassuring to have the private tabs and the icon close to each other

Yes, but that was more in the context of a future forward solution AIUI (I'll share the slack thread so you have more context on last weeks discussion or you can reach out to Yulia and Ania directly). Since we're in the last week of Nightly and we need to get this fix in for 133 we don't have time for anything other than treating this as a bug fix however we can consider further changes for rolling vertical tabs out to all users.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d13448b2fe7
Show private browsing indicator icon in navbar when vertical tabs are enabled r=desktop-theme-reviewers,sidebar-reviewers,fluent-reviewers,jsudiaman,dao,sfoster

Comment 11

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/0d13448b2fe7

Comment 12

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

I was able to reproduce the issue on an affected Firefox Nightly build from 2024-10-09, using Windows 11, while following the steps from Comment 0.
Verified as fixed on Firefox 133.0b8 using Windows 11, macOS 14.7 and Ubuntu 22.04. The private browsing icon is displayed as shown in the screenshot from Comment 8.