1927329 - Private window purple mask icon in titlebar has disappeared for vertical tabs

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Kestrel]

Attachment: Comparison of private windows before and after regression

STR:

1. Start with sidebar.verticalTabs = true.
2. Open a private window.

Expected:
Purple mask icon in titlebar next to window controls.

Actual:
No purple mask icon in titlebar.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=810a76d6befb8ab7770a1abd0f078c4fef01efcb&tochange=87fbfe70fe7a63e68b052b0aa8b84484575b6a19

Regressed by Bug 1922307.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:sfoster, since you are the author of the regressor, bug 1922307, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Jonathan Sudiaman [:jsudiaman]]

Attachment: Bug 1927329 - Update CSS rule using tabs-hidden to query the correct element. r?sfoster

Comment 3

[Sam Foster [:sfoster] (he/him)]

Thanks for flagging me.

The patch on bug 1922307 moved the tabs-hidden attribute off the #nav-bar and into the#navigator-toolbox element. So the selectors that show/hide the private-browsing indicator in the nav-bar broke. I.e. #nav-bar[tabs-hidden] isn't a thing anymore. You need #navigator-toolbox[tabs-hidden] > #nav-bar. I see this pattern at browser-shared.css#530 and browser-shared.css#526

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb4774ac5f80
Update CSS rule using tabs-hidden to query the correct element. r=sfoster,desktop-theme-reviewers

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/fb4774ac5f80

Comment 6

[Jonathan Sudiaman [:jsudiaman]]

Attachment: Bug 1927329 - Update CSS rule using tabs-hidden to query the correct element. r?sfoster

Original Revision: https://phabricator.services.mozilla.com/D227112

Comment 7

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Private windows using vertical tabs will not show the purple mask icon.
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Enable Vertical Tabs from Firefox Labs. Open a new private window. Verify that the private browsing indicator is on the top-right corner.
• Risk associated with taking this patch: Low
• Explanation of risk level: CSS fixes impacting only the private browsing indicator container.
• String changes made/needed: None.
• Is Android affected?: no

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/21a6db7ccaf6

Comment 9

[Giorgia Nichita, Release Desktop QA]

Reproduced this issue on an affected Nightly build using Win 10 and Ubuntu 22.04.
Verified as fixed on Nightly 134.0a1 (20241030214633) and Firefox beta 133.0b2 (20241030091715) across the folowing platforms: Win 10, Win 11, macOS 11 and UBuntu 22.04.