Closed
Bug 1923081
Opened 4 months ago
Closed 4 months ago
ODR violation in toolkit/components/url-classifier
Categories
(Firefox Build System :: General: Unsupported Platforms, defect)
Firefox Build System
General: Unsupported Platforms
Tracking
(firefox133 fixed)
RESOLVED
FIXED
133 Branch
Tracking | Status | |
---|---|---|
firefox133 | --- | fixed |
People
(Reporter: sergesanspaille, Assigned: sergesanspaille)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
GCC reports several ODR violation due to types having extra members in different CU
Assignee | ||
Comment 1•4 months ago
|
||
It is used to conditionally set a structure field, so it's required
that all compilation unit using it have the same value for that define.
The easiest way to achieve that goal is to set the define globally.
Updated•4 months ago
|
Attachment #9429320 -
Attachment description: Bug 1923081 - set define MOZ_SAFEBROWSING_DUMP_FAILED_UPDATES globally → WIP: Bug 1923081 - set define MOZ_SAFEBROWSING_DUMP_FAILED_UPDATES globally
Updated•4 months ago
|
Attachment #9429320 -
Attachment description: WIP: Bug 1923081 - set define MOZ_SAFEBROWSING_DUMP_FAILED_UPDATES globally → Bug 1923081 - set define MOZ_SAFEBROWSING_DUMP_FAILED_UPDATES globally
Pushed by sguelton@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/574660ebcc7d
set define MOZ_SAFEBROWSING_DUMP_FAILED_UPDATES globally r=dimi
Comment 3•4 months ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 4 months ago
status-firefox133:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•