Open Bug 1516758 Opened Last year Updated 8 months ago

-Wodr: C++ One Definition Rule violations in Firefox

Categories

(Firefox Build System :: General: Unsupported Platforms, defect, P5)

Product:
Firefox Build System
Component:
General: Unsupported Platforms
Version:
64 Branch
Type:
defect

Tracking

(Not tracked)

Status:
UNCONFIRMED

People

(Reporter: jh, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

odr.txt
18.24 KB, text/plain
Details
Attached file odr.txt — 
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

I built Firefox with GCC 8 and LTO


Actual results:

I got warnings about ODR vilations


Expected results:

There should be no warnigs
Blocks: 1455279
Here is the kind of warnings:
/aux/hubicka/firefox-2018/release/security/ct/CTLogVerifier.h:29:7: warning: type ‘struct CTLogVerifier’ violates the C++ One Definition Rule [-Wodr]
Blocks: build-gcc-8
No longer blocks: 1455279
Summary: C++ One Definition Rule violations in Firefox → -Wodr: C++ One Definition Rule violations in Firefox
Component: Untriaged → General: Unsupported Platforms
Product: Firefox → Firefox Build System
Note that the log I attached is produced by GCC9 where I made the warning hopefully more understandable.  Some of issues are easy to fix because they are caused by misplaced forward declarations that should be in proper name-space.  I will try to get around preparing patch for them.
Blocks: build-gcc-9
No longer blocks: build-gcc-8
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.