Open Bug 1923121 Opened 15 days ago Updated 2 hours ago

Account Hub Extract Auto Discovery Logic To Module

Categories

(Thunderbird :: Account Manager, task)

Tracking

(Not tracked)

REOPENED
133 Branch

People

(Reporter: vineet, Assigned: vineet)

References

(Blocks 2 open bugs)

Details

(Keywords: checkin-needed-tb)

Attachments

(1 file)

This task is for extracting the current autodiscovery logic from accountSetup.js and moving it to a module called FindConfig.sys.mjs, and adding tests to ensure correct functionality.

** How to Test **

  • Fill in fields in first step of account hub
  • Test ability to cancel (hit back) mid search
  • After line 476 in email.mjs, console log the config
  • You should see the right config associated with the email inputted in your console
Attachment #9430004 - Attachment description: WIP: Bug 1923121 - Account Hub extract find config to it's own module. → WIP: Bug 1923121 - Account Hub extract findConfig to it's own module.
Attachment #9430004 - Attachment description: WIP: Bug 1923121 - Account Hub extract findConfig to it's own module. → Bug 1923121 - Account Hub extract findConfig to it's own module. r=#thunderbird-reviewers
Attachment #9430004 - Attachment description: Bug 1923121 - Account Hub extract findConfig to it's own module. r=#thunderbird-reviewers → WIP: Bug 1923121 - Account Hub extract findConfig to it's own module.
Attachment #9430004 - Attachment description: WIP: Bug 1923121 - Account Hub extract findConfig to it's own module. → Bug 1923121 - Account Hub extract findConfig to it's own module. r=#thunderbird-reviewers
Blocks: 1925870
Target Milestone: --- → 133 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/61ee2a219836
Account Hub extract findConfig to it's own module. r=arschmitz,darktrojan

Status: ASSIGNED → RESOLVED
Closed: 16 hours ago
Resolution: --- → FIXED

This is causing a crash in the test - https://treeherder.mozilla.org/jobs?repo=comm-central&selectedTaskRun=W_4uQVx5Tbak_X9tkW-VGQ.0
Sheriffs, please back out for next push

Flags: needinfo?(vineet)
Flags: needinfo?(brendan)

Backout by brendan@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/90081ead21ee
Backed out changeset 61ee2a219836 for causing test failures. r=backout

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Flags: needinfo?(brendan)
Flags: needinfo?(vineet)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: