1923205 - [Toolbar redesign] PWA shows empty toolbar space as soon as the page is touched (regression affecting old toolbar)

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect, P1)

Description

[Markus Stange [:mstange]]

[Tracking Requested - why for this release]: noticeable regression for PWA users

Steps to reproduce

1. Configure the address bar to be at the top. It doesn't matter whether the new navbar is enabled or not.
2. Install a PWA, for example https://phanpy.social/ , by opening the page in Firefox, going to the three dot menu, and tapping "Add to Home screen".
3. Open the PWA.
4. Interact with the page.

Expected behavior

No blank space at the top should appear. PWAs don't show the Firefox toolbar.

Actual behavior

As soon as the finger touches the page, a toolbar-sized blank space appears at the top, and the bottom of the PWA is pushed offscreen and cut off.

Device information

• Firefox version: Nightly with GV 133.0a1-20241006093023
• Android device model: Samsung Galaxy S21
• Android OS version: 14

Any additional information?

This is a recent regression. It first appeared in the Play Store build that my device received last Friday (2024-10-04).

Comment 1

[Donal Meehan [:dmeehan]]

:royang could this be triaged and prioritized? (pinging as triage owner)
Could you help identify the regressor too?
There are several toolbar related changes that would have first hit nightly release on 2024-10-04
See here and here, though it's possible it could be something that landed in an different build.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox133 (nightly). However, the bug still isn't assigned.

:royang, could you please find an assignee for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1923205 - part 1 - Allow PWAs to remove dynamic behavior for the engine view r=#android-reviewers

The important change (and only change needed to fix the bug) is to remove EngineViewClippingBehavior
which would update how the engine view is displayed to account for the dynamic toolbars if in PWAs we
don't show toolbars.

Since we want the same functionality for configuring toolbars and the engine view when toolbars
should be hidden in a PWA or when entering fullscreen and also when toolbars should be shown again
we'll use now same methods in both places which encapsulate this potentially brittle code.

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1923205 - part 2 - Avoid dynamic behavior for the engine view when in a PWA after screen rotation r=#android-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8064e15d5a6e
part 1 - Allow PWAs to remove dynamic behavior for the engine view r=android-reviewers,skhan
https://hg.mozilla.org/integration/autoland/rev/46ebda11a5ce
part 2 - Avoid dynamic behavior for the engine view when in a PWA after screen rotation r=android-reviewers,skhan

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/8064e15d5a6e
https://hg.mozilla.org/mozilla-central/rev/46ebda11a5ce