1923289 - [X11, no compositing] Menu popups have double border on left or bottom side

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Artem S. Tashkinov]

Attachment: right click menu 130

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:131.0) Gecko/20100101 Firefox/131.0

Steps to reproduce:

Right click menus in Linux under X11 with no compositing look different in 131 than they were in 130. Check the screenshots.

Comment 1

[Artem S. Tashkinov]

Attachment: right click menu 131

Comment 2

[Artem S. Tashkinov]

Attachment: triple menu 130

Comment 3

[Artem S. Tashkinov]

Attachment: triple menu 131

Comment 4

[Artem S. Tashkinov]

Menus are not rounded and there's a weird black bar on the right side? Shadow? Doesn't look like shadow.

Comment 5

[Artem S. Tashkinov]

It's on the right or at the bottom.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1923289 - Don't report popups as transparent in uncomposited screens. r=stransky

This makes us choose the right rounding mode in nsView::CalcWidgetBounds
in order to prevent seams.

Remove composited screen special case which is no longer relevant now
that the X11 shape mask code is gone.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1913104

Comment 9

[Artem S. Tashkinov]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #7)

Created attachment 9429580 [details]
Bug 1923289 - Don't report popups as transparent in uncomposited screens. r=stransky

This makes us choose the right rounding mode in nsView::CalcWidgetBounds
in order to prevent seams.

Remove composited screen special case which is no longer relevant now
that the X11 shape mask code is gone.

Are you saying rounded corners are also forever gone for non-composited environments?

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Yes, I don't think we want to maintain the X11 shape mask code just for this kind of environment.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff97d79c8c17
Don't report popups as transparent in uncomposited screens. r=stransky

Comment 12

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/ff97d79c8c17

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox132 to wontfix.

For more information, please visit BugBot documentation.

Comment 14

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9429580 [details]
Bug 1923289 - Don't report popups as transparent in uncomposited screens. r=stransky

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0 (XFCE with compositing disabled)
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only affects non-compositing window managers.
• String changes made/needed: none
• Is Android affected?: No

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9429580 [details]
Bug 1923289 - Don't report popups as transparent in uncomposited screens. r=stransky

Approved for 132.0b6.

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/4c92a557d9ea

Comment 17

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Unfortunately, I was unable to reproduce the issue on Firefox 131.0, using Linux Fedora 40 (VM), X11, with compositing disabled, for the app menu / context menus. However, I was able to see the black border at the bottom of the tab hover preview.
I can confirm that the black border is no longer displayed at the bottom of the tab hover preview using Firefox 132.0b6 and Firefox 133.0a1 (2024-10-13), on Linux Fedora 40 (VM), X11, with compositing disabled. Also, the corners of the menus are no longer rounded.
@aros, could you please confirm that the issue is no longer reproducing on your end as well, using Firefox 132.0b6 / latest Nightly build? Thanks in advance!