[X11, no compositing] Menu popups have double border on left or bottom side
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr128 | --- | unaffected |
firefox131 | --- | affected |
firefox132 | --- | fixed |
firefox133 | --- | fixed |
People
(Reporter: aros, Assigned: emilio)
References
(Regression)
Details
(Keywords: regression)
Attachments
(5 files)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:131.0) Gecko/20100101 Firefox/131.0
Steps to reproduce:
Right click menus in Linux under X11 with no compositing look different in 131 than they were in 130. Check the screenshots.
Reporter | ||
Comment 1•2 days ago
|
||
Reporter | ||
Comment 2•2 days ago
|
||
Reporter | ||
Comment 3•2 days ago
|
||
Reporter | ||
Updated•2 days ago
|
Reporter | ||
Updated•2 days ago
|
Reporter | ||
Comment 4•2 days ago
|
||
Menus are not rounded and there's a weird black bar on the right side? Shadow? Doesn't look like shadow.
Reporter | ||
Comment 5•2 days ago
|
||
It's on the right or at the bottom.
Comment 6•2 days ago
|
||
The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.
Updated•2 days ago
|
Assignee | ||
Updated•2 days ago
|
Assignee | ||
Comment 7•2 days ago
|
||
This makes us choose the right rounding mode in nsView::CalcWidgetBounds
in order to prevent seams.
Remove composited screen special case which is no longer relevant now
that the X11 shape mask code is gone.
Updated•2 days ago
|
Comment 8•2 days ago
|
||
Set release status flags based on info from the regressing bug 1913104
Reporter | ||
Comment 9•2 days ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #7)
Created attachment 9429580 [details]
Bug 1923289 - Don't report popups as transparent in uncomposited screens. r=stranskyThis makes us choose the right rounding mode in nsView::CalcWidgetBounds
in order to prevent seams.Remove composited screen special case which is no longer relevant now
that the X11 shape mask code is gone.
Are you saying rounded corners are also forever gone for non-composited environments?
Assignee | ||
Comment 10•2 days ago
|
||
Yes, I don't think we want to maintain the X11 shape mask code just for this kind of environment.
Updated•2 days ago
|
Comment 11•2 days ago
|
||
Comment 12•2 days ago
|
||
bugherder |
Comment 13•1 day ago
|
||
The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox132
towontfix
.
For more information, please visit BugBot documentation.
Assignee | ||
Comment 14•1 day ago
|
||
Comment on attachment 9429580 [details]
Bug 1923289 - Don't report popups as transparent in uncomposited screens. r=stransky
Beta/Release Uplift Approval Request
- User impact if declined: comment 0
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: comment 0 (XFCE with compositing disabled)
- List of other uplifts needed: none
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Only affects non-compositing window managers.
- String changes made/needed: none
- Is Android affected?: No
Assignee | ||
Updated•1 day ago
|
Comment 15•20 hours ago
|
||
Comment on attachment 9429580 [details]
Bug 1923289 - Don't report popups as transparent in uncomposited screens. r=stransky
Approved for 132.0b6.
Updated•20 hours ago
|
Comment 16•20 hours ago
|
||
uplift |
Description
•