1913104 - Remove X11 mask code.

Status: RESOLVED FIXED

(Core :: Widget: Gtk, task)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1913104 - Remove X11 mask code. r=stransky

We're unlikely to use this code in the near future (we already cannot
use it in Mutter). Let's get rid of it.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

This one is still used on old systems or without compositing, on ESR lines and so on. So better to keep it here.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #2)

This one is still used on old systems or without compositing, on ESR lines and so on. So better to keep it here.

Can you elaborate? It's disabled on GNOME, is it somehow needed elsewhere?

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Context here is that Vlad was pondering to stop making X shapes work in KDE (in XWayland only perhaps?).

Comment 5

[Vlad Zahorodnii [:zzag]]

(in XWayland only perhaps?).

Yeah, xwayland only.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #2)

This one is still used on old systems or without compositing, on ESR lines and so on. So better to keep it here.

My understanding is that with no compositing, we have solid-csd (and thus no rounded corners), and with compositing, we use transparency (and thus masking is not needed), is that somehow not true?

Comment 7

[Martin Stránský [:stransky] (ni? me)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #6)

My understanding is that with no compositing, we have solid-csd (and thus no rounded corners), and with compositing, we use transparency (and thus masking is not needed), is that somehow not true?

AFAIK its used for popus - do the all have sharp/non transparent corners with solid-csd?

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Ah, that is right, e.g. on I3 menu rounded corners break.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

It may also break twm and similar ones used on RHEL systems, Firefox used over VNC and so on.

Comment 10

[Emilio Cobos Álvarez [:emilio]]

Would you be fine removing the titlebar mask (which is unused) while not removing the more general mask?

If so happy to do that.

Comment 11

[Emilio Cobos Álvarez [:emilio]]

Ok, I looked a bit at other toolkits and platforms:

• QT makes the menus and such square, so they look good.
• GTK and Chromium just show artifacts in the corners.

I tweaked the patch to avoid using rounded corners and shadows:

  /* On some linux WMs we need to draw square menus because alpha is not available */
  @media (-moz-platform: linux) and (not (-moz-gtk-csd-available)) {
    --panel-shadow-margin: 0px !important;
    --panel-border-radius: 0px !important;
  }

I think that's better than all the untested-on-automation shape mask code, wdyt?

Comment 12

[Martin Stránský [:stransky] (ni? me)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #11)

I think that's better than all the untested-on-automation shape mask code, wdyt?

Okay, no problem.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2822f96450d4
Remove X11 mask code. r=stransky,desktop-theme-reviewers,dao

Comment 14

[Sandor Molnar[:smolnar]]

Backed out for causing dt failures @ browser_rules_container-queries.js & bc failures @ browser_ext_popup_corners.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/6d938ca8ad61edf08860e366b951be7995aaab2c

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_container-queries.js | Test timed out

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_popup_corners.js | Panel and view borderTopLeftRadius should be the same

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3e33b1c2438
Remove X11 mask code. r=stransky,desktop-theme-reviewers,dao

Comment 16

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d3e33b1c2438