Remove X11 mask code.
Categories
(Core :: Widget: Gtk, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox131 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(1 file)
Assignee | ||
Comment 1•2 months ago
|
||
We're unlikely to use this code in the near future (we already cannot
use it in Mutter). Let's get rid of it.
Comment 2•2 months ago
|
||
This one is still used on old systems or without compositing, on ESR lines and so on. So better to keep it here.
Assignee | ||
Comment 3•2 months ago
|
||
(In reply to Martin Stránský [:stransky] (ni? me) from comment #2)
This one is still used on old systems or without compositing, on ESR lines and so on. So better to keep it here.
Can you elaborate? It's disabled on GNOME, is it somehow needed elsewhere?
Assignee | ||
Comment 4•2 months ago
|
||
Context here is that Vlad was pondering to stop making X shapes work in KDE (in XWayland only perhaps?).
Comment 5•2 months ago
|
||
(in XWayland only perhaps?).
Yeah, xwayland only.
Assignee | ||
Comment 6•2 months ago
|
||
(In reply to Martin Stránský [:stransky] (ni? me) from comment #2)
This one is still used on old systems or without compositing, on ESR lines and so on. So better to keep it here.
My understanding is that with no compositing, we have solid-csd (and thus no rounded corners), and with compositing, we use transparency (and thus masking is not needed), is that somehow not true?
Comment 7•2 months ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #6)
My understanding is that with no compositing, we have solid-csd (and thus no rounded corners), and with compositing, we use transparency (and thus masking is not needed), is that somehow not true?
AFAIK its used for popus - do the all have sharp/non transparent corners with solid-csd?
Assignee | ||
Comment 8•2 months ago
|
||
Ah, that is right, e.g. on I3 menu rounded corners break.
Comment 9•2 months ago
|
||
It may also break twm and similar ones used on RHEL systems, Firefox used over VNC and so on.
Assignee | ||
Comment 10•2 months ago
|
||
Would you be fine removing the titlebar mask (which is unused) while not removing the more general mask?
If so happy to do that.
Assignee | ||
Comment 11•2 months ago
|
||
Ok, I looked a bit at other toolkits and platforms:
- QT makes the menus and such square, so they look good.
- GTK and Chromium just show artifacts in the corners.
I tweaked the patch to avoid using rounded corners and shadows:
/* On some linux WMs we need to draw square menus because alpha is not available */
@media (-moz-platform: linux) and (not (-moz-gtk-csd-available)) {
--panel-shadow-margin: 0px !important;
--panel-border-radius: 0px !important;
}
I think that's better than all the untested-on-automation shape mask code, wdyt?
Comment 12•2 months ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #11)
I think that's better than all the untested-on-automation shape mask code, wdyt?
Okay, no problem.
Updated•2 months ago
|
Comment 13•2 months ago
|
||
Comment 14•2 months ago
|
||
Backed out for causing dt failures @ browser_rules_container-queries.js & bc failures @ browser_ext_popup_corners.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/6d938ca8ad61edf08860e366b951be7995aaab2c
Assignee | ||
Updated•2 months ago
|
Comment 15•2 months ago
|
||
Comment 16•2 months ago
|
||
bugherder |
Description
•