1923334 - Titlebar not following color scheme of theme dynamically.

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

STR:

• Check "titlebar" checkbox in customize mode.
• If you're on Light mode, switch to a dark firefox theme, or vice versa.

ER:

• Titlebar updates to match the theme color.

AR: Titlebar gets stuck.

This is also important for the sidebar translucency, since otherwise the sidebar background wouldn't change color scheme dynamically.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1923334 - Implement nsWindow::SetColorScheme on Windows. r=#win-reviewers

This makes things like comment 0 work as expected.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1923334 - Sync window properties when root element style changes. r=rkraesig,#layout

We sync window properties every time we reflow the viewport frame:

• https://searchfox.org/mozilla-central/rev/7db217e3832e9a884be0c2300779e098f92be3fe/layout/base/PresShell.cpp#9978-9980

However that's not enough because some things that do affect the window
properties (like border-radius / background-color / color-scheme) don't
necessarily trigger reflow.

Do it whenever we set the root style, which is easier and catches all
those.

Bail out earlier in content processes because we can, puppet widgets
don't do any of that.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a618db242979
Implement nsWindow::SetColorScheme on Windows. r=win-reviewers,rkraesig

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a618db242979

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae9869b408a6
Sync window properties when root element style changes. r=jwatt

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/ae9869b408a6

Comment 7

[Andra Esanu (needinfo me)]

(In reply to Pulsebot from comment #5)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae9869b408a6
Sync window properties when root element style changes. r=jwatt

Perfherder has detected a talos performance change from push ae9869b408a6b0672affa759d10420d4704af2ac.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
11%	tresize	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	23.23 -> 20.60
11%	tresize	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	23.31 -> 20.71
8%	tresize	linux1804-64-shippable-qr	e10s fission stylo webrender	23.17 -> 21.29
4%	tart	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	1.88 -> 1.80

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 2477

For more information on performance sheriffing please see our FAQ.

Comment 8

[Ray Kraesig [:rkraesig]]

I suspect the cause of this slowdown has been misidentified, but pinging :emilio anyway.

Comment 9

[Emilio Cobos Álvarez [:emilio]]

It's not a slowdown tho, it's a speedup. Actually it's not impossible, since it was a cross-platform change, and tresize reflows the viewport, but doesn't change root styles. So we're actually doing less work.

Comment 10

[Ada C.]

I was able to reproduce the issue on Win10x64 using Firefox build 133.0a1 (2024-10-08).
Verified as fixed on Win10x64 and macOS 13.6 ARM using Firefox build 134.0a1 and 133.0b9.