1923593 - drag-n-drop from all tabs list to bookmarks toolbar creates two different bookmarks

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P3)

Description

[[:mighty-bug]]

Attachment: Screencast from 10-09-2024 02:51:14 PM.webm

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:130.0) Gecko/20100101 Firefox/130.0

Steps to reproduce:

show bookmars toolbar
open multiple tabs
open 'list all tabs' dropdown menu
drag one item from that list and drop on the bookmarks toolbar

Actual results:

two bookmarks created:
currently opened page
the page you dragged from the list

Expected results:

one bookmark created:
the page you dragged from the list

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Tabbed Browser' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ecb328de1aafc36765b3bbf7f434ef84d93cad28&tochange=af1fc1e6eb24573a5ebad1754b9d4917e934a5f9

In the former build, the item in the List All Tabs menupopup cannot be dragged.
And in the latter build, this bug appears.
So, This issue is a side effect of the fix for bug 1771831.

Comment 3

[BugBot [:suhaib / :marco]]

:arai, since you are the author of the regressor, bug 1771831, could you take a look?

For more information, please visit BugBot documentation.

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1923593 - Ignore the active tab when handling drag and drop for the tab list. r?mak!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b0a40cced3f
Ignore the active tab when handling drag and drop for the tab list. r=mak,tabbrowser-reviewers

Comment 6

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/1b0a40cced3f

Comment 7

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-10-09 Nightly build on Windows 10.
Issue is verified as fixed on Firefox 133.0b4 and Firefox Nightly 134.0a1 on Windows 10, Ubuntu 22, macOS 14.