1771831 - Make "List all tabs" item drag-reorder-able

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement)

Description

[Tooru Fujisawa [:arai]]

Steps to reproduce:

1. Open 20 tabs: https://en.wikipedia.org/wiki/0 to https://en.wikipedia.org/wiki/9 , twice
2. click "List all tabs" drop down
3. Drag "3 - Wikipedia" and drop below "6 - Wikipedia"

Expected result:
The tab for "3 - Wikipedia" is moved after "6 - Wikipedia"

Actual result:
Nothing happens

The tab list is handy for locating the tab, and making it possible to reorder within it would be handy.

Bug 506195 is related, that it's about drag/drop between the "List all tabs" list and the tab bar.
This bug is drag/drop within the "List all tabs" list.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1771831 - Make it possible to reorder tabs in "List all tabs" list by drag-and-drop. r?dao!

Comment 2

[Tooru Fujisawa [:arai]]

The WIP patch above adds support for drag-and-drop within the "List all tabs".

Dragging the item outside of the list does nothing, because the data transfer has no generic data type, such as text/x-moz-text-internal.
This is intentional for this specific change, because setting it results in duplicating the tab if it's dropped onto the tab bar.

To properly support drag-and-drop between tab bar and tab list, both side needs to handle data type each other.

Comment 3

[Tooru Fujisawa [:arai]]

This becomes really necessary for me when handling many bugs at once (e.g. bug 1608279 and dependencies)

Comment 4

[Tooru Fujisawa [:arai]]

The following works:

• When tab list item is dragged, start the actual tab's drag, with special flag
• Accept the tab drag in the tab list
• Tweak the tab container to receive the tab drag with the special flag

It achieves:

• tab list item can be reordered within it
• tab list item can be dragged to tab bar to reorder
• tab list item can be detached by dragging to empty area

So far, given the tab list is automatically closed by clicking others, no need to accept drop from outside of the tab list

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f47d9c27992d
Make it possible to reorder tabs in "List all tabs" list by drag-and-drop. r=NeilDeakin

Comment 6

[Atila Butkovits]

Backed out for causing failures at browser_tabdetach.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/b21346d89c3d8fed117420e780964cf51a723d96

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=f47d9c27992db9424ae386932210a5c73c973289

Failure log: https://treeherder.mozilla.org/logviewer?job_id=388973595&repo=autoland&lineNumber=4671

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad968b0af681
Make it possible to reorder tabs in "List all tabs" list by drag-and-drop. r=NeilDeakin

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ad968b0af681