Closed Bug 1923765 Opened 2 years ago Closed 2 years ago

Messages that don't have a storeToken shouldn't have the offline flag

Categories

(MailNews Core :: General, task)

Product:
MailNews Core
Component:
General
Type:
task

Tracking

(thunderbird_esr128 fixed, thunderbird132 fixed)

Status:
RESOLVED FIXED
Milestone:
133 Branch
Tracking Flags:
Tracking Status
thunderbird_esr128 --- fixed
thunderbird132 --- fixed

People

(Reporter: darktrojan, Assigned: darktrojan)

References

Details

Attachments

(3 external files)

There's no point in claiming to have a message stored offline if we don't know where to find it. The storeToken value is what points to a stored offline message, so if there is no value, we should clear the flag.

Keywords: checkin-needed-tb

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/728ebecfb915
Clear the offline flag when trying to load messages with no storeToken. r=BenC
https://hg.mozilla.org/comm-central/rev/af8e417b57c0
Test what happens if a new message arrives while the folder is locked. r=john.bieling

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED

Comment on attachment 9430039 [details]
Bug 1923765 - Clear the offline flag when trying to load messages with no storeToken. r=BenC,#thunderbird-reviewers

Patch 5 of a pile of 6 for the corrupted message issue.

[Approval Request Comment]
Regression caused by (bug #): not a regression
User impact if declined: some faulty messages could download again and again and never be stored
Testing completed (on c-c, etc.): 4 days on central
Risk to taking this patch (and alternatives if risky): low

Attachment #9430039 - Flags: approval-comm-beta?

Comment on attachment 9430075 [details]
Bug 1923765 - Test what happens if a new message arrives while the folder is locked. r=#thunderbird-reviewers

Patch 6 of a pile of 6 for the corrupted message issue.

[Approval Request Comment]
Regression caused by (bug #): not a regression
User impact if declined: none, this is a test
Testing completed (on c-c, etc.): 4 days on central
Risk to taking this patch (and alternatives if risky): very low

Attachment #9430075 - Flags: approval-comm-beta?

Comment on attachment 9430039 [details]
Bug 1923765 - Clear the offline flag when trying to load messages with no storeToken. r=BenC,#thunderbird-reviewers

[Triage Comment]
Approved for beta

Attachment #9430039 - Flags: approval-comm-beta? → approval-comm-beta+

Comment on attachment 9430075 [details]
Bug 1923765 - Test what happens if a new message arrives while the folder is locked. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Attachment #9430075 - Flags: approval-comm-beta? → approval-comm-beta+

Bug 1911916 has not yet been uplifted to comm-esr128, so these tests don't have dates in the mbox files they create.

Comment on attachment 9430039 [details]
Bug 1923765 - Clear the offline flag when trying to load messages with no storeToken. r=BenC,#thunderbird-reviewers

[Approval Request Comment]
See comment 4.

Attachment #9430039 - Flags: approval-comm-esr128?

Comment on attachment 9430075 [details]
Bug 1923765 - Test what happens if a new message arrives while the folder is locked. r=#thunderbird-reviewers

[Approval Request Comment]
See comment 5.

Attachment #9430075 - Flags: approval-comm-esr128?

Comment on attachment 9432129 [details]
Bug 1923765 - [ESR128] Modify tests so they pass on this branch. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): This is a temporary patch to fix the tests until bug 1911916 also lands on comm-esr128, then it will need removing.
User impact if declined: None.
Testing completed (on c-c, etc.): This try run.
Risk to taking this patch (and alternatives if risky): Nope.

Attachment #9432129 - Flags: approval-comm-esr128?

Comment on attachment 9430039 [details]
Bug 1923765 - Clear the offline flag when trying to load messages with no storeToken. r=BenC,#thunderbird-reviewers

[Triage Comment]
Approved for esr128

Attachment #9430039 - Flags: approval-comm-esr128? → approval-comm-esr128+

Comment on attachment 9430075 [details]
Bug 1923765 - Test what happens if a new message arrives while the folder is locked. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr128

Attachment #9430075 - Flags: approval-comm-esr128? → approval-comm-esr128+

(In reply to Geoff Lankow (:darktrojan) from comment #12)

Comment on attachment 9432129 [details]
Bug 1923765 - [ESR128] Modify tests so they pass on this branch. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): This is a temporary patch to fix the tests until bug 1911916 also lands on comm-esr128, then it will need removing.
User impact if declined: None.
Testing completed (on c-c, etc.): This try run.
Risk to taking this patch (and alternatives if risky): Nope.

I'm holding off on approving this as there is a chance bug 1911916 may get uplifted to 128 in this release.

Comment on attachment 9432129 [details]
Bug 1923765 - [ESR128] Modify tests so they pass on this branch. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr128
We can revert if bug 1911916 gets uplifted.

Attachment #9432129 - Flags: approval-comm-esr128? → approval-comm-esr128+

Backed out changeset 84f49037eb35 from comm-esr128:
https://hg.mozilla.org/releases/comm-esr128/rev/c2902a5b97ae

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: