1923747 - IMAP folders accept messages piped over from IMAP protocol, even if folder is locked.

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Ben Campbell]

Quick background:

When nsImapProtocol downloads messages, it pipes them over to the folder via nsImapMailFolder::ParseAdoptedMsgLine() (which is an nsIImapMessageSink method).

There are a couple of problems here that need fixing:

1. nsImapMailFolder::ParseAdoptedMsgLine() happily accepts incoming messages from the protocol code, even if the folder is locked (eg during a folder compaction). It should check for this, and fail if the folder is locked.
2. nsImapProtocol calls ParseAdoptedMsgLine(), but never checks to see if it succeeded or not.

Comment 1

[Ben Campbell]

Attachment: Bug 1923747 - Reject message transfer from nsImapProtocol to locked folders. r=#thunderbird-reviewers

This changes nsImapMailFolder::ParseAdoptedMsgLine() to fail when trying to
start a new message when the folder is locked (eg due to folder compaction).
It also changes nsImapProtocol to check the return code from
ParseAdoptedMsgLine() and to abort the whole operation if a failure is
returned.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/840378229bd1
Reject message transfer from nsImapProtocol to locked folders. r=darktrojan

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9430026 [details]
Bug 1923747 - Reject message transfer from nsImapProtocol to locked folders. r=#thunderbird-reviewers

Patch 4 of a pile of 6 for the corrupted message issue.

[Approval Request Comment]
Regression caused by (bug #): probably always happened, seems to be more obvious after the compact folders rewrite
User impact if declined: can lead to messages appearing corrupt
Testing completed (on c-c, etc.): 4 days on central
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Corey Bryant]

Comment on attachment 9430026 [details]
Bug 1923747 - Reject message transfer from nsImapProtocol to locked folders. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 5

[Corey Bryant]

Thunderbird 132.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/f16042e8d548

Comment 6

[Geoff Lankow (:darktrojan)]

Comment on attachment 9430026 [details]
Bug 1923747 - Reject message transfer from nsImapProtocol to locked folders. r=#thunderbird-reviewers

[Approval Request Comment]
See comment 3.

Comment 7

[Corey Bryant]

Comment on attachment 9430026 [details]
Bug 1923747 - Reject message transfer from nsImapProtocol to locked folders. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr128

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 128.3.3esr:
https://hg.mozilla.org/releases/comm-esr128/rev/11e3be3f0e27