1923868 - Support setting Firefox as default based on installer attribution campaign

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Meg Viar [:mviar]]

This bug is for implementing a means of setting Firefox as the default browser based on the presence of a set_default_browser attribution campaign.

See brief for related experiment.

Comment 1

[Meg Viar [:mviar]]

Attachment: WIP: Bug 1923868 - Support setting Firefox as default based on installer attribution campaign

Comment 2

[Meg Viar [:mviar]]

Attachment: Bug 1923868 - Support setting Firefox as default based on installer attribution campaign

Comment 3

[Meg Viar [:mviar]]

[Tracking Requested - why for this release]: We'd like to land this patch to support an experiment in Fx132. Because it's gated behind an attribution campaign, it should be relatively low risk.

Comment 4

[Meg Viar [:mviar]]

To allow time for review, we'll target Fx133.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/893b697b0ad7
Support setting Firefox as default based on installer attribution campaign r=firefox-desktop-core-reviewers ,nalexander,omc-reviewers,pdahiya

Comment 6

[agoloman]

Backed out for causing bc failures @nsMacDockSupport.mm.

• Backout link
• Push with failures
• Failure Log
  ————————————————————————————————————
• Push with failures bc failures @browser_aboutwelcome_upgrade_multistage_mr.js
• Failure Log

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/60b9a1ba2d2e
Backed out changeset 893b697b0ad7 for causing bc failures @nsMacDockSupport.mm. CLOSED TREE

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2435b289727
Support setting Firefox as default based on installer attribution campaign r=firefox-desktop-core-reviewers ,nalexander,omc-reviewers,pdahiya

Comment 9

[Meg Viar [:mviar]]

Thanks for flagging the failure, I've updated the tests and have a green run on try so am attempting to re-land.

Comment 10

[amarc]

Backout merged to mozilla-central: https://hg.mozilla.org/mozilla-central/rev/0247e2cbb51823d73beef5e45fd21a4846b3611b

Comment 11

[amarc]

Backed out for causing bc failures @ browser_aboutwelcome_multistage_languageSwitcher.js

• Backout link
• Push with failures
• Failure Log
• Failure line:

TEST-UNEXPECTED-FAIL | browser/components/aboutwelcome/tests/browser/browser_aboutwelcome_multistage_languageSwitcher.js | Uncaught exception in test bound test_aboutwelcome_languageSwitcher_accept - Should render .screen.AW_LANGUAGE_MISMATCH in Live language switching (waiting for languages) - timed out after 50 tries.

————————————————————————————

• Push with failures
• Failure Log
• Failure line:

Assertion failure: aAppPath != aAppToReplacePath || !aAppPath.IsEmpty(), at /builds/worker/checkouts/gecko/widget/cocoa/nsMacDockSupport.mm:396

Comment 12

[Meg Viar [:mviar]]

Ah, sorry about that. Appears I was playing a bit of test failure whack-a-mole. I think I have a final fix, verifying on try now.

Comment 13

[Meg Viar [:mviar]]

I was able to address the test failure and will land after 134 Nightly merges and request uplift into early beta (try run).

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29ac96cd10ee
Support setting Firefox as default based on installer attribution campaign r=firefox-desktop-core-reviewers ,nalexander,omc-reviewers,pdahiya

Comment 15

[Meg Viar [:mviar]]

[Tracking Requested - why for this release]: We'll be seeking uplift into early 134 beta to support the related experiment and to match the current release schedule we're working towards with the marketing team.

Comment 16

[Meg Viar [:mviar]]

Attachment: Bug 1923868 - Support setting Firefox as default based on installer attribution campaign

This patch adds an startup idle task that sets the browser as default if an attribution campaign id of "set_default_browser" is present on first run. This works supports an upcoming experiment where users will have the option to "download as default" via [[ https://www.mozilla.org/en-US/firefox/new/ | the stub installer marketing page ]].

Original Revision: https://phabricator.services.mozilla.com/D225212

Comment 17

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Users will be unable to participate in the upcoming experiment allowing them to set Firefox as default from the marketing page where they download the stub installer
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: See test plan below
• Risk associated with taking this patch: Low
• Explanation of risk level: Fairly low as the behavior in this patch is only triggered when the relevent campaign attribution is present
• String changes made/needed: No
• Is Android affected?: no

Comment 18

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/29ac96cd10ee

Comment 19

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/71d0b6a24be2

Comment 20

[Ryan VanderMeulen [:RyanVM]]

Please don't change random bug flags. This is the second time now and interferes with people trying to get their work done.