Closed Bug 1924206 Opened 1 year ago Closed 8 months ago

Implement scoping structure for anchors, for elements specifying `anchor-scope`

Categories

(Core :: Layout: Positioned, enhancement)

Product:
Core
Component:
Layout: Positioned
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
144 Branch
Tracking Flags:
Tracking Status
firefox144 --- fixed

People

(Reporter: dshin, Assigned: jari)

References

(Blocks 1 open bug)

Details

(Whiteboard: [anchorpositioning:m2])

Attachments

(3 files, 4 obsolete files)

Bug 1924206: Check if anchor name is in scope for positioned frames. r=#anchor-positioning-reviewers
48 bytes, text/x-phabricator-request
Details
Bug 1924206: Remove some const correctness warnings. r=#anchor-positioning-reviewers
48 bytes, text/x-phabricator-request
Details
Bug 1924206: Update wpt tests for anchor scope without tree-scoped names. r=#anchor-positioning-reviewers
48 bytes, text/x-phabricator-request
Details

As per spec.

All or some of anchor names defined in this element or its descendants may be scoped to its descendants.

Whiteboard: [anchorpositioning:m1]
Assignee: nobody → jwatt
Assignee: jwatt → nobody
Whiteboard: [anchorpositioning:m1] → [anchorpositioning:m2]
Assignee: nobody → jjalkanen
Attachment #9509887 - Attachment description: WIP: Bug 1924206: Rename other gFlags variable to avoid unified build issues. r=#anchor-positioning-reviewers → Bug 1924206: Rename other gFlags variable to avoid unified build issues. r=#anchor-positioning-reviewers
Attachment #9509888 - Attachment description: WIP: Bug 1924206: Keep track of anchor scopes in PresShell. r=#anchor-positioning-reviewers → Bug 1924206: Keep track of anchor scopes in PresShell. r=#anchor-positioning-reviewers
Attachment #9510269 - Attachment description: WIP: Bug 1924206: Remove some const correctness warnings. r=#anchor-positioning-reviewers → Bug 1924206: Remove some const correctness warnings. r=#anchor-positioning-reviewers
Attachment #9509889 - Attachment description: WIP: Bug 1924206: Check if anchor name is in scope for positioned frames. r=#anchor-positioning-reviewers → Bug 1924206: Check if anchor name is in scope for positioned frames. r=#anchor-positioning-reviewers

Comment on attachment 9509887 [details]
Bug 1924206: Rename other gFlags variable to avoid unified build issues. r=#anchor-positioning-reviewers

Revision D262823 was moved to bug 1986329. Setting attachment 9509887 [details] to obsolete.

Attachment #9509887 - Attachment is obsolete: true
Attachment #9509888 - Attachment is obsolete: true
Attachment #9510391 - Attachment description: Bug 1924206: Update wpt tests. r=#anchor-positioning-reviewers → Bug 1924206: Update wpt tests depending on tree-scoped names. r=#anchor-positioning-reviewers
Attachment #9510699 - Attachment description: Bug 1924206: Update wpt tests for anchor scope without tree-scoping. r=#anchor-positioning-reviewers → Bug 1924206: Update wpt tests for anchor scope without tree-scoped names. r=#anchor-positioning-reviewers
Blocks: 1986347

https://hg.mozilla.org/mozilla-central/rev/379a80398b87

Status: NEW → RESOLVED
Closed: 8 months ago
status-firefox144: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 144 Branch
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Blocks: 1986602

Comment on attachment 9510390 [details]
Bug 1924206: Check if anchor scope is relevant in shadow tree. r=#anchor-positioning-reviewers

Revision D263074 was moved to bug 1986602. Setting attachment 9510390 [details] to obsolete.

Attachment #9510390 - Attachment is obsolete: true

Comment on attachment 9510391 [details]
Bug 1924206: Update wpt tests depending on tree-scoped names. r=#anchor-positioning-reviewers

Revision D263147 was moved to bug 1986602. Setting attachment 9510391 [details] to obsolete.

Attachment #9510391 - Attachment is obsolete: true
Blocks: 1987086
Pushed by jjalkanen@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/316d6ba0f41e https://hg.mozilla.org/integration/autoland/rev/99ce31b9df7d Check if anchor name is in scope for positioned frames. r=layout-anchor-positioning-reviewers,layout-reviewers,dshin,jwatt https://github.com/mozilla-firefox/firefox/commit/fd0d576ae3e9 https://hg.mozilla.org/integration/autoland/rev/a1ee4a794b24 Update wpt tests for anchor scope without tree-scoped names. r=jwatt

https://hg.mozilla.org/mozilla-central/rev/99ce31b9df7d
https://hg.mozilla.org/mozilla-central/rev/a1ee4a794b24

Status: REOPENED → RESOLVED
Closed: 8 months ago → 8 months ago
status-firefox144: affected → fixed
Resolution: --- → FIXED
QA Whiteboard: [qa-triage-done-c145/b144]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: